Skip to content

sync: TestCondBroadcast failures #61874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
gopherbot opened this issue Aug 8, 2023 · 6 comments
Closed

sync: TestCondBroadcast failures #61874

gopherbot opened this issue Aug 8, 2023 · 6 comments
Labels
arch-riscv Issues solely affecting the riscv64 architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Backlog

Comments

@gopherbot
Copy link
Contributor

gopherbot commented Aug 8, 2023 •
edited by bcmills
Loading 

#!watchflakes
post <- pkg == "sync" && test == "TestCondBroadcast" && goarch == "riscv64" && date < "2023-08-25"

Issue created automatically to collect these failures.

Example (log):

panic: test timed out after 12m0s
running tests:
	TestCondBroadcast (12m0s)

runtime.gopark(0x3f88054180?, 0x3f8822a000?, 0x6?, 0x0?, 0x779a0?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/proc.go:398 +0x10c fp=0x3f88036640 sp=0x3f88036628 pc=0x49f0c
runtime.chanrecv(0x3f880aa700, 0x3f88036720, 0x1?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:583 +0x430 fp=0x3f880366b8 sp=0x3f88036640 pc=0x15178
runtime.chanrecv1(0x295500?, 0xc8?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:442 +0x14 fp=0x3f880366d8 sp=0x3f880366b8 pc=0x14d2c
sync_test.TestCondBroadcast(0x3f88082340)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/sync/cond_test.go:116 +0x3f8 fp=0x3f88036778 sp=0x3f880366d8 pc=0x1199e0
testing.tRunner(0x3f88082340, 0x17c2a8)

— watchflakes
@gopherbot gopherbot added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 8, 2023
@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
default <- pkg == "sync" && test == "TestCondBroadcast"
2023-08-08 17:51 linux-riscv64-unmatched go@0c13bd63 sync.TestCondBroadcast (log) 
panic: test timed out after 12m0s
running tests:
	TestCondBroadcast (12m0s)

runtime.gopark(0x3f88054180?, 0x3f8822a000?, 0x6?, 0x0?, 0x779a0?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/proc.go:398 +0x10c fp=0x3f88036640 sp=0x3f88036628 pc=0x49f0c
runtime.chanrecv(0x3f880aa700, 0x3f88036720, 0x1?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:583 +0x430 fp=0x3f880366b8 sp=0x3f88036640 pc=0x15178
runtime.chanrecv1(0x295500?, 0xc8?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:442 +0x14 fp=0x3f880366d8 sp=0x3f880366b8 pc=0x14d2c
sync_test.TestCondBroadcast(0x3f88082340)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/sync/cond_test.go:116 +0x3f8 fp=0x3f88036778 sp=0x3f880366d8 pc=0x1199e0
testing.tRunner(0x3f88082340, 0x17c2a8)

— watchflakes

@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Aug 8, 2023
@bcmills
Copy link
Contributor

bcmills commented Aug 9, 2023

(attn @golang/riscv64)

@mknyszek mknyszek added this to the Backlog milestone Aug 9, 2023
@mknyszek mknyszek added help wanted arch-riscv Issues solely affecting the riscv64 architecture. labels Aug 9, 2023
@mengzhuo
Copy link
Contributor

I ran 10000 Broadcast test without issue.

@bcmills
Copy link
Contributor

bcmills commented Aug 15, 2023

A lot of these low-level hard-to-reproduce bugs turn out to be corruption in signal handlers. Maybe the failure depends on some other (perhaps CPU-bound) test running concurrently, causing the runtime to self-signal for preemption?

@gopherbot
Copy link
Contributor Author

Found new dashboard test flakes for:

#!watchflakes
post <- pkg == "sync" && test == "TestCondBroadcast" && goarch == "riscv64"
2023-08-09 14:36 linux-riscv64-unmatched go@288fd6eb sync.TestCondBroadcast (log) 
panic: test timed out after 8m0s
running tests:
	TestCondBroadcast (8m0s)

runtime.gopark(0x3fa000e240?, 0x3fa01dd1e0?, 0x6?, 0x0?, 0x77a30?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/proc.go:398 +0x10c fp=0x3fa0036640 sp=0x3fa0036628 pc=0x49f2c
runtime.chanrecv(0x3fa019a700, 0x3fa0036720, 0x1?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:583 +0x430 fp=0x3fa00366b8 sp=0x3fa0036640 pc=0x15178
runtime.chanrecv1(0x295500?, 0xc8?)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/runtime/chan.go:442 +0x14 fp=0x3fa00366d8 sp=0x3fa00366b8 pc=0x14d2c
sync_test.TestCondBroadcast(0x3fa0192000)
	/tmp/workdir-host-linux-riscv64-unmatched/go/src/sync/cond_test.go:116 +0x3f8 fp=0x3fa0036778 sp=0x3fa00366d8 pc=0x119a48
testing.tRunner(0x3fa0192000, 0x17c2a8)

— watchflakes

@mengzhuo
Copy link
Contributor

Related: #62185
Closed.

@github-project-automation github-project-automation bot moved this from Todo to Done in Go Compiler / Runtime Aug 25, 2023
@golang golang locked and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
arch-riscv Issues solely affecting the riscv64 architecture. compiler/runtime Issues related to the Go compiler and/or runtime. FrozenDueToAge help wanted NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Test Flakes
Archived in project
Milestone
Backlog
Development

No branches or pull requests
4 participants
@mengzhuo @mknyszek @bcmills @gopherbot