Skip to content

cmd/trace: tolerate Go 1.22+ traces with broken tails #65316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mknyszek opened this issue Jan 26, 2024 · 1 comment
Closed

cmd/trace: tolerate Go 1.22+ traces with broken tails #65316

mknyszek opened this issue Jan 26, 2024 · 1 comment
Assignees
@mknyszek
Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Milestone
Go1.23

Comments

@mknyszek
Copy link
Contributor

Because Go 1.22+ traces are partitioned, it's possible to isolate broken partitions and remove them from the trace data. This is especially useful if a crash happens while tracing.

Currently cmd/trace rejects any trace that isn't completely parseable, but it could easily discard a broken trace tail and report how much of the trace it discarded.
@gopherbot gopherbot added the compiler/runtime Issues related to the Go compiler and/or runtime. label Jan 26, 2024
@mknyszek mknyszek added this to the Backlog milestone Jan 26, 2024
@mknyszek mknyszek added the FeatureRequest Issues asking for a new feature that does not need a proposal. label Jan 26, 2024
@mknyszek mknyszek changed the title cmd/trace: tolerate traces with broken tails cmd/trace: tolerate Go 1.22+ traces with broken tails Jan 26, 2024
@mknyszek mknyszek mentioned this issue Jan 26, 2024
Closed
@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Jan 26, 2024
@mknyszek mknyszek self-assigned this Jan 31, 2024
@mknyszek mknyszek moved this from Todo to In Progress in Go Compiler / Runtime Apr 18, 2024
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/580135 mentions this issue: cmd/trace/v2: tolerate traces with broken tails

@github-project-automation github-project-automation bot moved this from In Progress to Done in Go Compiler / Runtime Apr 19, 2024
@nsrip-dd nsrip-dd mentioned this issue May 23, 2024
Closed
@dmitshur dmitshur modified the milestones: Backlog, Go1.23 May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mknyszek mknyszek

Labels
compiler/runtime Issues related to the Go compiler and/or runtime. FeatureRequest Issues asking for a new feature that does not need a proposal. NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one.
Projects
Go Compiler / Runtime
Status: Done
Milestone
Go1.23
Development

No branches or pull requests
4 participants
@mknyszek @dmitshur @gopherbot @cherrymui