Skip to content

crypto/tls: Using GODEBUG=tlsrsakex=1 behaves inconsistently between Go 1.22 and master #68528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cuiweixie opened this issue Jul 20, 2024 · 2 comments

Comments

@cuiweixie
Copy link
Contributor

          I think this is controlled by the GODEBUG setting `tlsrsakex` where the default changed from enabled in go1.21 to disabled in go1.22.

I don't think there's anything to do here as the new behavior is more correct and we aren't going to change the default GODEBUG for a previous version.

main » GODEBUG=tlsrsakex=1 go1.22.5 run .
2024/07/19 12:18:46 dial failed: websocket: bad handshake
exit status 1


main » GODEBUG=tlsrsakex=0 go1.22.5 run . 
2024/07/19 12:18:56 connection ok

Originally posted by @seankhliao in #68522 (comment)

@cuiweixie
Copy link
Contributor Author

main » GODEBUG=tlsrsakex=1 gomaster run . 
result in  connection ok

I found is caused by cl585437
before this cl.

 GODEBUG=tlsrsakex=1 go run .
dial failed: websocket: bad handshake
exit status 1

please help to explain why this happen.

@seankhliao
Copy link
Member

Sounds like an issue with the server being sensitive to extension ordering.

Unlike many projects, the Go project does not use GitHub Issues for general discussion or asking questions. GitHub Issues are used for tracking bugs and proposals only.

For questions please refer to https://github.com/golang/go/wiki/Questions

@seankhliao seankhliao closed this as not planned Won't fix, can't repro, duplicate, stale Jul 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants