Skip to content

x/exp/typeparams: TestAPIConsistency fail with Go tip since CL 575455 #69000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
cherrymui opened this issue Aug 21, 2024 · 3 comments
Closed
Assignees
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Milestone

Comments

@cherrymui
Copy link
Member

cherrymui commented Aug 21, 2024

The x/exp repo started to fail consistently since CL 575455 (on the main repo). E.g.
https://ci.chromium.org/ui/p/golang/builders/ci/x_exp-gotip-linux-amd64/b8738967462680113393/test-results

=== RUN   TestAPIConsistency
    typeparams_test.go:39: "*TypeList.Types": got func()(Seq[Type]) at 1.18+, but  at 1.17
    typeparams_test.go:39: "*TypeParamList.TypeParams": got func()(Seq[*TypeParam]) at 1.18+, but  at 1.17
    typeparams_test.go:39: "*Union.Terms": got func()(Seq[*Term]) at 1.18+, but  at 1.17
--- FAIL: TestAPIConsistency (0.63s)

cc @adonovan @findleyr

@cherrymui cherrymui added the NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. label Aug 21, 2024
@cherrymui cherrymui added this to the Unreleased milestone Aug 21, 2024
@gabyhelp
Copy link

Related Issues and Documentation

(Emoji vote if this was helpful or unhelpful; more detailed feedback welcome in this discussion.)

@findleyr findleyr self-assigned this Aug 21, 2024
@findleyr
Copy link
Member

Thanks, I'll take a look.

@gopherbot
Copy link
Contributor

Change https://go.dev/cl/607895 mentions this issue: typeparams: don't complain that Go 1.17 doesn't support iterators

@dmitshur dmitshur added NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure. and removed NeedsInvestigation Someone must examine and confirm this is a valid issue and not a duplicate of an existing one. labels Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
NeedsFix The path to resolution is known, but the work has not been done. Testing An issue that has been verified to require only test changes, not just a test failure.
Projects
None yet
Development

No branches or pull requests

6 participants