Skip to content

x/tools/gopls: crashes due to apparent data race (gopls v16+ on linux) #71425

Open
2 of 15 issues completed
Open
@findleyr

Description

@findleyr

While we've found and fixed many gopls crashes thanks to telemetry, as we gain more users it appears we're accumulating a long tail of issues that "can't happen" based on easily verifiable local invariants.

In some cases, these were related to misreporting of stacks by the runtime (#70637), but others cannot be explained by a misreported stack, and indicate some form of memory corruption or (most likely) data race.

This issue is an umbrella for those bugs. @adonovan and I will consolidate them here.

Sub-issues

Sub-issues

2 of 15 Issues completed

Activity

added
ToolsThis label describes issues relating to any tools in the x/tools repository.
goplsIssues related to the Go language server, gopls.
on Jan 24, 2025
added this to the Unreleased milestone on Jan 24, 2025

14 remaining items

adonovan

adonovan commented on Mar 14, 2025

@adonovan
Member

@findleyr Perhaps you could run gopls built with -race for a while? I've been doing it on my mac, but no problems so far.

adonovan

adonovan commented on Mar 18, 2025

@adonovan
Member

The latest associated issue (#72931) is something new:

  • golang.org/x/tools/gopls@v0.18.1 go1.23.6 linux/amd64 vscode (1)
added
gopls/file-corruptionIssues related to file corruption in gopls
gopls/memory-corruption"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)
on Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    BugReportIssues describing a possible bug in the Go implementation.ToolsThis label describes issues relating to any tools in the x/tools repository.goplsIssues related to the Go language server, gopls.gopls/file-corruptionIssues related to file corruption in goplsgopls/memory-corruption"can't happen" gopls crashes (races, unsafe, miscompile, runtime bugs, faulty HW)gopls/telemetry-wins

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

      Development

      No branches or pull requests

        Participants

        @adonovan@gopherbot@findleyr@gabyhelp

        Issue actions

          x/tools/gopls: crashes due to apparent data race (gopls v16+ on linux) · Issue #71425 · golang/go