diff --git a/proto/test_proto/test.pb.go b/proto/test_proto/test.pb.go index 703853b321..c99f79f196 100644 --- a/proto/test_proto/test.pb.go +++ b/proto/test_proto/test.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: test_proto/test.proto -package test_proto // import "github.com/golang/protobuf/proto/test_proto" +package test_proto import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/descriptor/descriptor.pb.go b/protoc-gen-go/descriptor/descriptor.pb.go index 1e8285afc5..7beb1c2a63 100644 --- a/protoc-gen-go/descriptor/descriptor.pb.go +++ b/protoc-gen-go/descriptor/descriptor.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/descriptor.proto -package descriptor // import "github.com/golang/protobuf/protoc-gen-go/descriptor" +package descriptor import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/generator/generator.go b/protoc-gen-go/generator/generator.go index c61c1c26c8..96818cb80c 100644 --- a/protoc-gen-go/generator/generator.go +++ b/protoc-gen-go/generator/generator.go @@ -1208,12 +1208,7 @@ func (g *Generator) generateHeader() { } g.P() - importPath, _, _ := g.file.goPackageOption() - if importPath == "" { - g.P("package ", g.file.packageName) - } else { - g.P("package ", g.file.packageName, " // import ", GoImportPath(g.ImportPrefix)+importPath) - } + g.P("package ", g.file.packageName) g.P() if loc, ok := g.file.comments[strconv.Itoa(packagePath)]; ok { diff --git a/protoc-gen-go/golden_test.go b/protoc-gen-go/golden_test.go index 2630de68a4..2950eac75b 100644 --- a/protoc-gen-go/golden_test.go +++ b/protoc-gen-go/golden_test.go @@ -3,7 +3,6 @@ package main import ( "bytes" "flag" - "fmt" "go/build" "go/parser" "go/token" @@ -150,7 +149,7 @@ func TestParameters(t *testing.T) { wantPackageB: "test_beta", wantImportsA: map[string]bool{ "github.com/golang/protobuf/proto": true, - "beta": true, + "beta": true, }, }, { parameters: "import_prefix=prefix", @@ -323,64 +322,6 @@ func TestParameters(t *testing.T) { } } -func TestPackageComment(t *testing.T) { - workdir, err := ioutil.TempDir("", "proto-test") - if err != nil { - t.Fatal(err) - } - defer os.RemoveAll(workdir) - - var packageRE = regexp.MustCompile(`(?m)^package .*`) - - for i, test := range []struct { - goPackageOption string - wantPackage string - }{{ - goPackageOption: ``, - wantPackage: `package proto_package`, - }, { - goPackageOption: `option go_package = "go_package";`, - wantPackage: `package go_package`, - }, { - goPackageOption: `option go_package = "import/path/of/go_package";`, - wantPackage: `package go_package // import "import/path/of/go_package"`, - }, { - goPackageOption: `option go_package = "import/path/of/something;go_package";`, - wantPackage: `package go_package // import "import/path/of/something"`, - }, { - goPackageOption: `option go_package = "import_path;go_package";`, - wantPackage: `package go_package // import "import_path"`, - }} { - srcName := filepath.Join(workdir, fmt.Sprintf("%d.proto", i)) - tgtName := filepath.Join(workdir, fmt.Sprintf("%d.pb.go", i)) - - buf := &bytes.Buffer{} - fmt.Fprintln(buf, `syntax = "proto3";`) - fmt.Fprintln(buf, `package proto_package;`) - fmt.Fprintln(buf, test.goPackageOption) - if err := ioutil.WriteFile(srcName, buf.Bytes(), 0666); err != nil { - t.Fatal(err) - } - - protoc(t, []string{"-I" + workdir, "--go_out=paths=source_relative:" + workdir, srcName}) - - out, err := ioutil.ReadFile(tgtName) - if err != nil { - t.Fatal(err) - } - - pkg := packageRE.Find(out) - if pkg == nil { - t.Errorf("generated .pb.go contains no package line\n\nsource:\n%v\n\noutput:\n%v", buf.String(), string(out)) - continue - } - - if got, want := string(pkg), test.wantPackage; got != want { - t.Errorf("unexpected package statement with go_package = %q\n got: %v\nwant: %v", test.goPackageOption, got, want) - } - } -} - // parseFile returns a file's package name and a list of all packages it imports. func parseFile(source string) (packageName string, imports []string, err error) { fset := token.NewFileSet() diff --git a/protoc-gen-go/protoc-gen-go b/protoc-gen-go/protoc-gen-go deleted file mode 100755 index fcb8b10815..0000000000 Binary files a/protoc-gen-go/protoc-gen-go and /dev/null differ diff --git a/protoc-gen-go/testdata/deprecated/deprecated.pb.go b/protoc-gen-go/testdata/deprecated/deprecated.pb.go index e4e94c667c..c7c01d635c 100644 --- a/protoc-gen-go/testdata/deprecated/deprecated.pb.go +++ b/protoc-gen-go/testdata/deprecated/deprecated.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // deprecated/deprecated.proto is a deprecated file. -package deprecated // import "github.com/golang/protobuf/protoc-gen-go/testdata/deprecated" +package deprecated /* package deprecated contains only deprecated messages and services. diff --git a/protoc-gen-go/testdata/extension_base/extension_base.pb.go b/protoc-gen-go/testdata/extension_base/extension_base.pb.go index 18e91ed3fe..6931bebb00 100644 --- a/protoc-gen-go/testdata/extension_base/extension_base.pb.go +++ b/protoc-gen-go/testdata/extension_base/extension_base.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: extension_base/extension_base.proto -package extension_base // import "github.com/golang/protobuf/protoc-gen-go/testdata/extension_base" +package extension_base import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/extension_extra/extension_extra.pb.go b/protoc-gen-go/testdata/extension_extra/extension_extra.pb.go index 43a51f9a36..a6a3bc372d 100644 --- a/protoc-gen-go/testdata/extension_extra/extension_extra.pb.go +++ b/protoc-gen-go/testdata/extension_extra/extension_extra.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: extension_extra/extension_extra.proto -package extension_extra // import "github.com/golang/protobuf/protoc-gen-go/testdata/extension_extra" +package extension_extra import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/extension_user/extension_user.pb.go b/protoc-gen-go/testdata/extension_user/extension_user.pb.go index 67cc9023e1..c751f1e6ee 100644 --- a/protoc-gen-go/testdata/extension_user/extension_user.pb.go +++ b/protoc-gen-go/testdata/extension_user/extension_user.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: extension_user/extension_user.proto -package extension_user // import "github.com/golang/protobuf/protoc-gen-go/testdata/extension_user" +package extension_user import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/grpc/grpc.pb.go b/protoc-gen-go/testdata/grpc/grpc.pb.go index a930fb6d30..3829f6d2f6 100644 --- a/protoc-gen-go/testdata/grpc/grpc.pb.go +++ b/protoc-gen-go/testdata/grpc/grpc.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: grpc/grpc.proto -package testing // import "github.com/golang/protobuf/protoc-gen-go/testdata/grpc" +package testing import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/import_public/a.pb.go b/protoc-gen-go/testdata/import_public/a.pb.go index 42ff7e370a..4a830d9d0c 100644 --- a/protoc-gen-go/testdata/import_public/a.pb.go +++ b/protoc-gen-go/testdata/import_public/a.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: import_public/a.proto -package import_public // import "github.com/golang/protobuf/protoc-gen-go/testdata/import_public" +package import_public import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/import_public/b.pb.go b/protoc-gen-go/testdata/import_public/b.pb.go index d9968d94f2..8044e2e6d9 100644 --- a/protoc-gen-go/testdata/import_public/b.pb.go +++ b/protoc-gen-go/testdata/import_public/b.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: import_public/b.proto -package import_public // import "github.com/golang/protobuf/protoc-gen-go/testdata/import_public" +package import_public import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/import_public/sub/a.pb.go b/protoc-gen-go/testdata/import_public/sub/a.pb.go index 414f58bbcd..f01abaaf2e 100644 --- a/protoc-gen-go/testdata/import_public/sub/a.pb.go +++ b/protoc-gen-go/testdata/import_public/sub/a.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: import_public/sub/a.proto -package sub // import "github.com/golang/protobuf/protoc-gen-go/testdata/import_public/sub" +package sub import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/import_public/sub/b.pb.go b/protoc-gen-go/testdata/import_public/sub/b.pb.go index 7f21e2350c..abd08f0f4f 100644 --- a/protoc-gen-go/testdata/import_public/sub/b.pb.go +++ b/protoc-gen-go/testdata/import_public/sub/b.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: import_public/sub/b.proto -package sub // import "github.com/golang/protobuf/protoc-gen-go/testdata/import_public/sub" +package sub import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/fmt/m.pb.go b/protoc-gen-go/testdata/imports/fmt/m.pb.go index 5376f50e5f..02cc47fcee 100644 --- a/protoc-gen-go/testdata/imports/fmt/m.pb.go +++ b/protoc-gen-go/testdata/imports/fmt/m.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/fmt/m.proto -package fmt // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/fmt" +package fmt import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_a_1/m1.pb.go b/protoc-gen-go/testdata/imports/test_a_1/m1.pb.go index 4e286a5676..8681788130 100644 --- a/protoc-gen-go/testdata/imports/test_a_1/m1.pb.go +++ b/protoc-gen-go/testdata/imports/test_a_1/m1.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_a_1/m1.proto -package test_a_1 // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_a_1" +package test_a_1 import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_a_1/m2.pb.go b/protoc-gen-go/testdata/imports/test_a_1/m2.pb.go index a8abfc0ffa..dc9b2f316f 100644 --- a/protoc-gen-go/testdata/imports/test_a_1/m2.pb.go +++ b/protoc-gen-go/testdata/imports/test_a_1/m2.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_a_1/m2.proto -package test_a_1 // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_a_1" +package test_a_1 import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_a_2/m3.pb.go b/protoc-gen-go/testdata/imports/test_a_2/m3.pb.go index 91ee5d28e0..db2606cf7f 100644 --- a/protoc-gen-go/testdata/imports/test_a_2/m3.pb.go +++ b/protoc-gen-go/testdata/imports/test_a_2/m3.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_a_2/m3.proto -package test_a_2 // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_a_2" +package test_a_2 import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_a_2/m4.pb.go b/protoc-gen-go/testdata/imports/test_a_2/m4.pb.go index a6225d0313..807cbe7592 100644 --- a/protoc-gen-go/testdata/imports/test_a_2/m4.pb.go +++ b/protoc-gen-go/testdata/imports/test_a_2/m4.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_a_2/m4.proto -package test_a_2 // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_a_2" +package test_a_2 import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_b_1/m1.pb.go b/protoc-gen-go/testdata/imports/test_b_1/m1.pb.go index 55572c2bec..2789db94b2 100644 --- a/protoc-gen-go/testdata/imports/test_b_1/m1.pb.go +++ b/protoc-gen-go/testdata/imports/test_b_1/m1.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_b_1/m1.proto -package beta // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_b_1" +package beta import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_b_1/m2.pb.go b/protoc-gen-go/testdata/imports/test_b_1/m2.pb.go index 5d1f9c1cb5..cdc9848572 100644 --- a/protoc-gen-go/testdata/imports/test_b_1/m2.pb.go +++ b/protoc-gen-go/testdata/imports/test_b_1/m2.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_b_1/m2.proto -package beta // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports/test_b_1" +package beta import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_import_a1m1.pb.go b/protoc-gen-go/testdata/imports/test_import_a1m1.pb.go index 7d87e51ca3..3be6951bbf 100644 --- a/protoc-gen-go/testdata/imports/test_import_a1m1.pb.go +++ b/protoc-gen-go/testdata/imports/test_import_a1m1.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_import_a1m1.proto -package imports // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports" +package imports import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_import_a1m2.pb.go b/protoc-gen-go/testdata/imports/test_import_a1m2.pb.go index d792311c29..365204874f 100644 --- a/protoc-gen-go/testdata/imports/test_import_a1m2.pb.go +++ b/protoc-gen-go/testdata/imports/test_import_a1m2.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_import_a1m2.proto -package imports // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports" +package imports import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/imports/test_import_all.pb.go b/protoc-gen-go/testdata/imports/test_import_all.pb.go index e73b3479da..1d5fd09dc1 100644 --- a/protoc-gen-go/testdata/imports/test_import_all.pb.go +++ b/protoc-gen-go/testdata/imports/test_import_all.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: imports/test_import_all.proto -package imports // import "github.com/golang/protobuf/protoc-gen-go/testdata/imports" +package imports import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/multi/multi1.pb.go b/protoc-gen-go/testdata/multi/multi1.pb.go index 48837017a4..548eda5c83 100644 --- a/protoc-gen-go/testdata/multi/multi1.pb.go +++ b/protoc-gen-go/testdata/multi/multi1.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: multi/multi1.proto -package multitest // import "github.com/golang/protobuf/protoc-gen-go/testdata/multi" +package multitest import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/multi/multi2.pb.go b/protoc-gen-go/testdata/multi/multi2.pb.go index e4fa18c1dc..3c15cbe006 100644 --- a/protoc-gen-go/testdata/multi/multi2.pb.go +++ b/protoc-gen-go/testdata/multi/multi2.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: multi/multi2.proto -package multitest // import "github.com/golang/protobuf/protoc-gen-go/testdata/multi" +package multitest import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/multi/multi3.pb.go b/protoc-gen-go/testdata/multi/multi3.pb.go index 12c114f9fc..aa5d27b929 100644 --- a/protoc-gen-go/testdata/multi/multi3.pb.go +++ b/protoc-gen-go/testdata/multi/multi3.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: multi/multi3.proto -package multitest // import "github.com/golang/protobuf/protoc-gen-go/testdata/multi" +package multitest import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/protoc-gen-go/testdata/my_test/test.pb.go b/protoc-gen-go/testdata/my_test/test.pb.go index 6d4ec5e66e..e529079a5c 100644 --- a/protoc-gen-go/testdata/my_test/test.pb.go +++ b/protoc-gen-go/testdata/my_test/test.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: my_test/test.proto -package test // import "github.com/golang/protobuf/protoc-gen-go/testdata/my_test" +package test /* This package holds interesting messages. diff --git a/protoc-gen-go/testdata/proto3/proto3.pb.go b/protoc-gen-go/testdata/proto3/proto3.pb.go index 4d13095bf9..e8cd901669 100644 --- a/protoc-gen-go/testdata/proto3/proto3.pb.go +++ b/protoc-gen-go/testdata/proto3/proto3.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: proto3/proto3.proto -package proto3 // import "github.com/golang/protobuf/protoc-gen-go/testdata/proto3" +package proto3 import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/any/any.pb.go b/ptypes/any/any.pb.go index 704642c505..baf5314a50 100644 --- a/ptypes/any/any.pb.go +++ b/ptypes/any/any.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/any.proto -package any // import "github.com/golang/protobuf/ptypes/any" +package any import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/duration/duration.pb.go b/ptypes/duration/duration.pb.go index be9fb8f95f..3ee28de237 100644 --- a/ptypes/duration/duration.pb.go +++ b/ptypes/duration/duration.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/duration.proto -package duration // import "github.com/golang/protobuf/ptypes/duration" +package duration import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/empty/empty.pb.go b/ptypes/empty/empty.pb.go index 4c3a6fb1e8..4b21168f9c 100644 --- a/ptypes/empty/empty.pb.go +++ b/ptypes/empty/empty.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/empty.proto -package empty // import "github.com/golang/protobuf/ptypes/empty" +package empty import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/struct/struct.pb.go b/ptypes/struct/struct.pb.go index 732758485a..30ea5a63a3 100644 --- a/ptypes/struct/struct.pb.go +++ b/ptypes/struct/struct.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/struct.proto -package structpb // import "github.com/golang/protobuf/ptypes/struct" +package structpb import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/timestamp/timestamp.pb.go b/ptypes/timestamp/timestamp.pb.go index 5e1f4aab05..07aab885a4 100644 --- a/ptypes/timestamp/timestamp.pb.go +++ b/ptypes/timestamp/timestamp.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/timestamp.proto -package timestamp // import "github.com/golang/protobuf/ptypes/timestamp" +package timestamp import proto "github.com/golang/protobuf/proto" import fmt "fmt" diff --git a/ptypes/wrappers/wrappers.pb.go b/ptypes/wrappers/wrappers.pb.go index 770cde6cb8..1238ec647c 100644 --- a/ptypes/wrappers/wrappers.pb.go +++ b/ptypes/wrappers/wrappers.pb.go @@ -1,7 +1,7 @@ // Code generated by protoc-gen-go. DO NOT EDIT. // source: google/protobuf/wrappers.proto -package wrappers // import "github.com/golang/protobuf/ptypes/wrappers" +package wrappers import proto "github.com/golang/protobuf/proto" import fmt "fmt"