windows/svc: safe closure on error

utkarsh-extc · web-flow · commit 0c73a916facd · 2019-07-24T00:28:27.000+05:30
diff --git a/windows/svc/mgr/mgr.go b/windows/svc/mgr/mgr.go
@@ -152,6 +152,8 @@ func (m *Mgr) CreateService(name, exepath string, c Config, args ...string) (*Se
 	if c.DelayedAutoStart == ServiceDelayedAutoStartTrue {
 		err = updateStartUp(h, c.DelayedAutoStart)
 		if err != nil {
+			windows.DeleteService(h)
+			windows.CloseHandle(h)
 			return nil, err
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -152,6 +152,8 @@ func (m Mgr) CreateService(name, exepath string, c Config, args ...string) (Se`
`152`	`152`	`if c.DelayedAutoStart == ServiceDelayedAutoStartTrue {`
`153`	`153`	`err = updateStartUp(h, c.DelayedAutoStart)`
`154`	`154`	`if err != nil {`
	`155`	`+ windows.DeleteService(h)`
	`156`	`+ windows.CloseHandle(h)`
`155`	`157`	`return nil, err`
`156`	`158`	`}`
`157`	`159`	`}`