gopls/internal/bug: remove unused Data parameter

Change-Id: Iedef0b5a20bda8c5e3c82a7b763fbb8e659f2967
Reviewed-on: https://go-review.googlesource.com/c/tools/+/488615
gopls-CI: kokoro <[email protected]>
Run-TryBot: Alan Donovan <[email protected]>
Reviewed-by: Robert Findley <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>

Author: adonovan

gopls/internal/bug/bug.go

@@ -36,34 +36,30 @@ type Bug struct {
 	File        string // file containing the call to bug.Report
 	Line        int    // line containing the call to bug.Report
 	Description string // description of the bug
-	Data        Data   // additional metadata
 	Key         string // key identifying the bug (file:line if available)
 	Stack       string // call stack
 }
 
-// Data is additional metadata to record for a bug.
-type Data map[string]interface{}
-
 // Reportf reports a formatted bug message.
 func Reportf(format string, args ...interface{}) {
-	report(fmt.Sprintf(format, args...), nil)
+	report(fmt.Sprintf(format, args...))
 }
 
 // Errorf calls fmt.Errorf for the given arguments, and reports the resulting
 // error message as a bug.
 func Errorf(format string, args ...interface{}) error {
 	err := fmt.Errorf(format, args...)
-	report(err.Error(), nil)
+	report(err.Error())
 	return err
 }
 
 // Report records a new bug encountered on the server.
 // It uses reflection to report the position of the immediate caller.
-func Report(description string, data Data) {
-	report(description, data)
+func Report(description string) {
+	report(description)
 }
 
-func report(description string, data Data) {
+func report(description string) {
 	_, file, line, ok := runtime.Caller(2) // all exported reporting functions call report directly
 
 	key := "<missing callsite>"
@@ -79,7 +75,6 @@ func report(description string, data Data) {
 		File:        file,
 		Line:        line,
 		Description: description,
-		Data:        data,
 		Key:         key,
 		Stack:       string(debug.Stack()),
 	}

gopls/internal/bug/bug_test.go

@@ -17,12 +17,12 @@ func resetForTesting() {
 func TestListBugs(t *testing.T) {
 	defer resetForTesting()
 
-	Report("bad", nil)
+	Report("bad")
 
 	wantBugs(t, "bad")
 
 	for i := 0; i < 3; i++ {
-		Report(fmt.Sprintf("index:%d", i), nil)
+		Report(fmt.Sprintf("index:%d", i))
 	}
 
 	wantBugs(t, "bad", "index:0")
@@ -47,19 +47,16 @@ func wantBugs(t *testing.T, want ...string) {
 func TestBugNotification(t *testing.T) {
 	defer resetForTesting()
 
-	Report("unseen", nil)
+	Report("unseen")
 
 	notify1 := Notify()
 	notify2 := Notify()
 
-	Report("seen", Data{"answer": 42})
+	Report("seen")
 
 	for _, got := range []Bug{<-notify1, <-notify2} {
 		if got, want := got.Description, "seen"; got != want {
 			t.Errorf("Saw bug %q, want %q", got, want)
 		}
-		if got, want := got.Data["answer"], 42; got != want {
-			t.Errorf(`bug.Data["answer"] = %v, want %v`, got, want)
-		}
 	}
 }

gopls/internal/lsp/debug/serve.go

@@ -469,7 +469,7 @@ func (i *Instance) Serve(ctx context.Context, addr string) (string, error) {
 			http.Error(w, "OK", 200)
 		})
 		mux.HandleFunc("/_makeabug", func(w http.ResponseWriter, r *http.Request) {
-			bug.Report("bug here", nil)
+			bug.Report("bug here")
 			http.Error(w, "made a bug", http.StatusOK)
 		})
 

gopls/internal/regtest/debug/debug_test.go

@@ -24,7 +24,7 @@ func TestBugNotification(t *testing.T) {
 		Settings{"showBugReports": true},
 	).Run(t, "", func(t *testing.T, env *Env) {
 		const desc = "got a bug"
-		bug.Report(desc, nil)
+		bug.Report(desc)
 		env.Await(ShownMessage(desc))
 	})
 }