Skip to content

Commit 2de6fe5

Browse files
committed
internal/lsp: return error if there is no builtin package
When we stopped returning an error from awaitInitialized, we didn't handle this case in LookupBuiltin. Fixes golang/go#36975. Change-Id: I9668a7148f60ca1f9cad953d46caf6ec5500541e Reviewed-on: https://go-review.googlesource.com/c/tools/+/217399 Run-TryBot: Rebecca Stambler <[email protected]> TryBot-Result: Gobot Gobot <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent 90d7435 commit 2de6fe5

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

internal/lsp/cache/view.go

+3
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,9 @@ func (v *view) Rebuild(ctx context.Context) (source.Snapshot, error) {
206206
func (v *view) LookupBuiltin(ctx context.Context, name string) (*ast.Object, error) {
207207
v.awaitInitialized(ctx)
208208

209+
if v.builtin == nil {
210+
return nil, errors.Errorf("no builtin package for view %s", v.name)
211+
}
209212
data := v.builtin.handle.Get(ctx)
210213
if ctx.Err() != nil {
211214
return nil, ctx.Err()

0 commit comments

Comments
 (0)