Skip to content

Commit 3f7c326

Browse files
findleyrstamblerre
authored andcommitted
gopls/internal/regtest: skip the flaky TestResolveImportCycle
Also improve the description of the failing expectations. Updates golang/go#46773 Change-Id: I9465de8a5005bb7ee719a536f8550afc54bd6044 Reviewed-on: https://go-review.googlesource.com/c/tools/+/328369 Trust: Robert Findley <[email protected]> Run-TryBot: Robert Findley <[email protected]> gopls-CI: kokoro <[email protected]> TryBot-Result: Go Bot <[email protected]> Reviewed-by: Rebecca Stambler <[email protected]>
1 parent b12e617 commit 3f7c326

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

gopls/internal/regtest/diagnostics/diagnostics_test.go

+1
Original file line numberDiff line numberDiff line change
@@ -1618,6 +1618,7 @@ import _ "mod.com/triple/a"
16181618
// Tests golang/go#46667: deleting a problematic import path should resolve
16191619
// import cycle errors.
16201620
func TestResolveImportCycle(t *testing.T) {
1621+
t.Skip("flaky test: see golang/go#46773")
16211622
const mod = `
16221623
-- go.mod --
16231624
module mod.test

internal/lsp/regtest/expectation.go

+1-1
Original file line numberDiff line numberDiff line change
@@ -525,7 +525,7 @@ func EmptyDiagnostics(name string) Expectation {
525525
}
526526
return SimpleExpectation{
527527
check: check,
528-
description: "empty diagnostics",
528+
description: fmt.Sprintf("empty diagnostics for %q", name),
529529
}
530530
}
531531

0 commit comments

Comments
 (0)