Skip to content

Commit 4426aff

Browse files
committed
go/ssa/interp: disable regularly broken tests in short mode
Updates golang/go#27292 Change-Id: I845afc64ca9ed2065c3b5645b7ce6def290d7a6d Reviewed-on: https://go-review.googlesource.com/131717 Reviewed-by: Brad Fitzpatrick <[email protected]>
1 parent f6ba574 commit 4426aff

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

go/ssa/interp/interp_test.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,8 +103,8 @@ var gorootTestTests = []string{
103103
"floatcmp.go",
104104
"crlf.go", // doesn't actually assert anything (runoutput)
105105
// Slow tests follow.
106-
"bom.go", // ~1.7s
107-
"gc1.go", // ~1.7s
106+
"bom.go", // ~1.7s
107+
"gc1.go", // ~1.7s
108108
"cmplxdivide.go cmplxdivide1.go", // ~2.4s
109109

110110
// Working, but not worth enabling:
@@ -156,6 +156,9 @@ var testdataTests = []string{
156156
type successPredicate func(exitcode int, output string) error
157157

158158
func run(t *testing.T, dir, input string, success successPredicate) bool {
159+
if testing.Short() {
160+
t.Skip("test breaks regularly; skipping in short mode so a failure doesn't affect trybots or build.golang.org; golang.org/issue/27292")
161+
}
159162
if runtime.GOOS == "darwin" {
160163
t.Skip("skipping on darwin until golang.org/issue/23166 is fixed")
161164
}

0 commit comments

Comments
 (0)