Skip to content

Commit 6997d19

Browse files
committed
gopls/internal/regtest/misc: unskip TestMajorOptionsChange
This test was fixed in CL 494675, which forced snapshots to observe all overlays when updating the view. Updates golang/go#53878 Fixes golang/go#57934 Change-Id: I018bdd260255d6a630c7fc8788935fd69f5e7477 Reviewed-on: https://go-review.googlesource.com/c/tools/+/496883 TryBot-Result: Gopher Robot <[email protected]> Reviewed-by: Alan Donovan <[email protected]> gopls-CI: kokoro <[email protected]> Run-TryBot: Robert Findley <[email protected]>
1 parent ec543c5 commit 6997d19

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

gopls/internal/regtest/misc/configuration_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -57,9 +57,7 @@ var FooErr = errors.New("foo")
5757
//
5858
// Gopls should not get confused about buffer content when recreating the view.
5959
func TestMajorOptionsChange(t *testing.T) {
60-
t.Skip("broken due to golang/go#57934")
61-
62-
testenv.NeedsGo1Point(t, 17)
60+
testenv.NeedsGo1Point(t, 19) // needs staticcheck
6361

6462
const files = `
6563
-- go.mod --

0 commit comments

Comments
 (0)