Skip to content

Commit 778a20b

Browse files
author
Bryan C. Mills
committed
x/tools/gopls/internal/regtest/modfile: skip TestUnknownRevision and MultiModule tests on plan9
For golang/go#50477 For golang/go#50478 Change-Id: If2a9d175c06446db70628a21a1552e32239627c1 Reviewed-on: https://go-review.googlesource.com/c/tools/+/375876 Trust: Bryan Mills <[email protected]> Run-TryBot: Bryan Mills <[email protected]> gopls-CI: kokoro <[email protected]> Reviewed-by: Robert Findley <[email protected]>
1 parent a1300ed commit 778a20b

File tree

2 files changed

+9
-0
lines changed

2 files changed

+9
-0
lines changed

gopls/internal/regtest/modfile/modfile_test.go

+5
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ package modfile
66

77
import (
88
"path/filepath"
9+
"runtime"
910
"strings"
1011
"testing"
1112

@@ -513,6 +514,10 @@ require (
513514

514515
// Reproduces golang/go#38232.
515516
func TestUnknownRevision(t *testing.T) {
517+
if runtime.GOOS == "plan9" {
518+
t.Skipf("skipping test that fails for unknown reasons on plan9; see https://go.dev/issue/50477")
519+
}
520+
516521
testenv.NeedsGo1Point(t, 14)
517522

518523
const unknown = `

internal/lsp/tests/tests.go

+4
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ import (
1616
"os"
1717
"path/filepath"
1818
"regexp"
19+
"runtime"
1920
"sort"
2021
"strconv"
2122
"strings"
@@ -273,6 +274,9 @@ func RunTests(t *testing.T, dataDir string, includeMultiModule bool, f func(*tes
273274
if mode == "MultiModule" {
274275
// Some bug in 1.12 breaks reading markers, and it's not worth figuring out.
275276
testenv.NeedsGo1Point(t, 13)
277+
if runtime.GOOS == "plan9" {
278+
t.Skipf("MultiModule setup fails for undiagnosed reasons on plan9; see https://go.dev/issue/50478")
279+
}
276280
}
277281
datum := load(t, mode, dataDir)
278282
t.Helper()

0 commit comments

Comments
 (0)