internal/lsp/testdata: update for new diagnostic from go list

Now that go list reports import errors on the importing package,
update the disabled part of the test to expect that error. (We
commented out the line generating the diagnostic in the test before
making the change so that the change itself wouldn't generate a
diagnostic and break the test).

For golang/go#59157

Change-Id: I207f507c8e07dd55d3609ca2bb9bdf25528ec898
Reviewed-on: https://go-review.googlesource.com/c/tools/+/482999
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: David Chase <[email protected]>
Reviewed-by: Michael Matloob <[email protected]>
Run-TryBot: Michael Matloob <[email protected]>
Reviewed-by: Robert Findley <[email protected]>

Author: matloob

gopls/internal/lsp/testdata/bad/bad0_go121.go

@@ -5,7 +5,7 @@ package bad
 
 // TODO(matloob): uncomment this and remove the space between the // and the @diag
 // once the changes that produce the new go list error are submitted.
-// import _ "golang.org/lsptests/assign/internal/secret" // @diag("\"golang.org/lsptests/assign/internal/secret\"", "compiler", "could not import golang.org/lsptests/assign/internal/secret \\(invalid use of internal package \"golang.org/lsptests/assign/internal/secret\"\\)", "error"),diag("_", "go list", "use of internal package golang.org/lsptests/assign/internal/secret not allowed", "error")
+import _ "golang.org/lsptests/assign/internal/secret" //@diag("\"golang.org/lsptests/assign/internal/secret\"", "compiler", "could not import golang.org/lsptests/assign/internal/secret \\(invalid use of internal package \"golang.org/lsptests/assign/internal/secret\"\\)", "error"),diag("_", "go list", "use of internal package golang.org/lsptests/assign/internal/secret not allowed", "error")
 
 func stuff() { //@item(stuff, "stuff", "func()", "func")
 	x := "heeeeyyyy"

gopls/internal/lsp/testdata/summary_go1.21.txt.golden

@@ -8,7 +8,7 @@ DeepCompletionsCount = 5
 FuzzyCompletionsCount = 8
 RankedCompletionsCount = 174
 CaseSensitiveCompletionsCount = 4
-DiagnosticsCount = 41
+DiagnosticsCount = 43
 FoldingRangesCount = 2
 FormatCount = 6
 ImportCount = 8