Skip to content

Commit b4e093e

Browse files
dmitshurgopherbot
authored andcommitted
go/packages: run TestIssue70394 with Go 1.23
It's expected to pass now that the CL 631855 cherry-pick is submitted. Also apply gofmt after CL 637961 while here. For golang/go#70394. Change-Id: I436b24f86669af7c9a2ff06703732018ab2a9ffc Reviewed-on: https://go-review.googlesource.com/c/tools/+/640017 LUCI-TryBot-Result: Go LUCI <[email protected]> Reviewed-by: Dmitri Shuralyov <[email protected]> Reviewed-by: Tim King <[email protected]> Auto-Submit: Dmitri Shuralyov <[email protected]>
1 parent 16f2979 commit b4e093e

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

go/packages/packages_test.go

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3157,8 +3157,7 @@ func TestIssue69606b(t *testing.T) {
31573157
// in another package (m/b) where the types for m/b are coming from the compiler,
31583158
// e.g. `go list -compiled=true ... m/b`.
31593159
func TestIssue70394(t *testing.T) {
3160-
// TODO(taking): backport https://go.dev/cl/604099 so that this works on 23.
3161-
testenv.NeedsGo1Point(t, 24)
3160+
testenv.NeedsGo1Point(t, 23)
31623161
testenv.NeedsTool(t, "go") // requires go list.
31633162
testenv.NeedsGoBuild(t) // requires the compiler for export data.
31643163

@@ -3339,7 +3338,7 @@ func main() {
33393338

33403339
pkgs, err := packages.Load(&packages.Config{
33413340
Mode: packages.NeedName | packages.NeedTarget,
3342-
Env: append(os.Environ(), "GOPATH=" + gopath, "GO111MODULE=off"),
3341+
Env: append(os.Environ(), "GOPATH="+gopath, "GO111MODULE=off"),
33433342
}, filepath.Join(gopath, "src", "..."))
33443343
if err != nil {
33453344
t.Fatal(err)

0 commit comments

Comments
 (0)