Skip to content

gopls: orphaned server-initiated progress notification after restarting the language server #1153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hyangah opened this issue Jan 30, 2021 · 2 comments

Comments

@hyangah
Copy link
Contributor

hyangah commented Jan 30, 2021

Gopls uses window/workDoneProgress/create to notify users of long running server-side operations and for errors that require user action to resolve (e.g. Error loading workspace...).

I found this notification doesn't get cleared if the server restarts before the work is done or the user addresses the root cause.

Screen Shot 2021-01-30 at 1 32 51 PM

These orphaned notifications will not disappear without a complete reload of the window.
Considering this problem can occur when the language server crashes in the middle of work, I believe clearing this orphaned notification is client's responsibility. Having the vscode lsp client library handle this is ideal for us, but if it's not the case, we sill need to look into a way to track the notifications and clear them up before restarting the language server (maybe utilizing the new onProgress middleware).

@hyangah
Copy link
Contributor Author

hyangah commented Feb 1, 2021

We need to update the language client library to 7.0.0 that already includes the fix.
Unfortunately, 7.0.0 requires vscode engine 1.52+ (the latest official version).

@hyangah hyangah added this to the v0.23.0 milestone Feb 3, 2021
@gopherbot
Copy link
Collaborator

Change https://golang.org/cl/289389 mentions this issue: package.json: update LSP and DAP libraries

@hyangah hyangah modified the milestones: v0.23.0, On Deck Mar 2, 2021
@hyangah hyangah modified the milestones: On Deck, v0.23.1 Mar 10, 2021
@golang golang locked and limited conversation to collaborators Mar 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants