Skip to content

Debugging goes into proc.go at every step #1666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
qidi1 opened this issue Aug 5, 2021 · 7 comments
Closed

Debugging goes into proc.go at every step #1666

qidi1 opened this issue Aug 5, 2021 · 7 comments
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Milestone

Comments

@qidi1
Copy link

qidi1 commented Aug 5, 2021

I'm using go modules, and every debug step into or step over goes into a proc.go file gopark function and then goes back. You can see it in this gif. https://gyazo.com/adb4a54cc467ce372a4b5595b72d150f
launch.json

{
    // Use IntelliSense to learn about possible attributes.
    // Hover to view descriptions of existing attributes.
    // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387
    "version": "0.2.0",
    "configurations": [
        {
            "name": "Launch Package",
            "type": "go",
            "request": "launch",
            "mode": "test",
            "program": "${workspaceRoot}/server/core",
            "args":[
                "-check.f",
                "TestBasic"
            ],
        }
    ]
}

it is same problem like this microsoft/vscode-go#2133, it said this bug is already fixed but i meet this again,my vscode vesion is 1.58.2.0.

@gopherbot gopherbot added this to the Untriaged milestone Aug 5, 2021
@hyangah hyangah added the Debug Issues related to the debugging functionality of the extension. label Aug 5, 2021
@hyangah
Copy link
Contributor

hyangah commented Aug 5, 2021

This is a duplicate of #1647. The fix isn't released yet. We mark an issue as fixed when the fix is merged.

Release progress is tracked in #1659
In the mean time, try the new debug adapter (by adding the property "debugAdpater": "dlv-dap" to the configuration) or try the nightly extension.

@mgabeler-lee-6rs
Copy link

mgabeler-lee-6rs commented Aug 5, 2021

The original issue was tagged as fixed by microsoft/vscode#65920 which was closed as fixed in microsoft/vscode@2a0a6eb on January 23rd, 2019

Edit: general extra confusion of issues in the different iterations of this repo

@qidi1
Copy link
Author

qidi1 commented Aug 6, 2021

I lowered the vscode version to 1.57.1 ​​and the problem disappeared. I also tried vscode version 1.59.0 and the problem still exists. Maybe it's a problem with vscode,

@hyangah
Copy link
Contributor

hyangah commented Aug 9, 2021

Go extension v0.27.0 was just released. Please update the extension and see if it addressed the issue. Thanks!

@hyangah hyangah added the WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided. label Aug 9, 2021
@mgabeler-lee-6rs
Copy link

much improved, yes :D

I am getting this notification:

User specified 'dlvLoadConfig' setting will be ignored by debug adapter 'dlv-dap'.

I've got some valuable-to-me config there, is that planned to be supported for dlv-dap, or are things like maxStringLen in there no longer applicable and it will always show the whole thing?

@hyangah
Copy link
Contributor

hyangah commented Aug 9, 2021

dlv-dap uses a different approach for data loading - it loads more on demand. For strings, it also uses a large limit for default. See https://github.com/golang/vscode-go/blob/master/docs/debugging.md#settings
We hope maxStringLen is no longer necessary in most cases - if not, please let us know what limit you want to see. :-)

@hyangah
Copy link
Contributor

hyangah commented Aug 17, 2021

Delve DAP which didn't have this issue is now the default debug adapter. Moreover @suzmue fixed the root cause of the legacy debug adapter too and the fix was released in v0.27.0.
Closing.

@hyangah hyangah closed this as completed Aug 17, 2021
@golang golang locked and limited conversation to collaborators Aug 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Debug Issues related to the debugging functionality of the extension. FrozenDueToAge WaitingForInfo Issue is not actionable because of missing required information, which needs to be provided.
Projects
None yet
Development

No branches or pull requests

4 participants