Skip to content

Autocompletion does not consider partially entered identifier #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wtask opened this issue Jul 22, 2020 · 3 comments
Closed

Autocompletion does not consider partially entered identifier #390

wtask opened this issue Jul 22, 2020 · 3 comments
Labels
FrozenDueToAge upstream-tools Issues that are caused by problems in the tools that the extension depends on.

Comments

@wtask
Copy link

wtask commented Jul 22, 2020

Version: 1.47.2 (user setup)
Commit: 17299e413d5590b14ab0340ea477cdd86ff13daf
Date: 2020-07-15T18:22:06.216Z
Electron: 7.3.2
Chrome: 78.0.3904.130
Node.js: 12.8.1
V8: 7.8.279.23-electron.0
OS: Windows_NT x64 10.0.19041

Go extension 0.15.1

Start typing something able to complete with help of Go-extension. Press Ctrl+Space or wait when auto-completion drop-down will be opened. Press Enter or Tab to use suggested string. As result we got partially entered identifier concatenated with the whole identifier obtained with auto-completion. In other words, if auto-completion target is MyIdentifier and I typed MyId the final result is MyIdMyIndentifier. I really do not understand the vscode-go logic to use auto-completion.

@hyangah
Copy link
Contributor

hyangah commented Jul 22, 2020

@wtask Thanks for the report. Are you using the language server ("go.useLanguageServer": true in your settings)?
If so, can you check if golang/go#38600 describes your case?

Otherwise, please share your settings for further investigation. (Command Palette -> Preferences: Open Settings (JSON) -> find anything that starts with "go" , "[go]", "gopls")

@wtask
Copy link
Author

wtask commented Jul 22, 2020

@hyangah Looks like golang/go#38600
Yes, I use gopls

@hyangah hyangah added the upstream-tools Issues that are caused by problems in the tools that the extension depends on. label Jul 22, 2020
@hyangah
Copy link
Contributor

hyangah commented Jul 22, 2020

Thanks for checking and verifying it @wtask
Since this is the upstream gopls bug, let's close this and follow up in the upstream bug.

Duplicate of golang/go#38600.

@hyangah hyangah closed this as completed Jul 22, 2020
@golang golang locked and limited conversation to collaborators Jul 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
FrozenDueToAge upstream-tools Issues that are caused by problems in the tools that the extension depends on.
Projects
None yet
Development

No branches or pull requests

3 participants