chore: deprecate check-shadowing

Author: ldez

.golangci.next.reference.yml

@@ -1074,10 +1074,6 @@ linters-settings:
       - Katakana
 
   govet:
-    # Report about shadowed variables.
-    # Default: false
-    check-shadowing: true
-
     # Settings per analyzer.
     settings:
       # Analyzer name, run `go tool vet help` to see all analyzers.

jsonschema/golangci.next.jsonschema.json

@@ -1661,11 +1661,6 @@
           "type": "object",
           "additionalProperties": false,
           "properties": {
-            "check-shadowing": {
-              "description": "Report shadowed variables.",
-              "type": "boolean",
-              "default": true
-            },
             "settings": {
               "description": "Settings per analyzer. Map of analyzer name to specific settings.\nRun `go tool vet help` to find out more.",
               "type": "object",

pkg/config/linters_settings.go

@@ -598,14 +598,16 @@ type GosmopolitanSettings struct {
 }
 
 type GovetSettings struct {
-	Go             string `mapstructure:"-"`
-	CheckShadowing bool   `mapstructure:"check-shadowing"`
-	Settings       map[string]map[string]any
+	Go       string `mapstructure:"-"`
+	Settings map[string]map[string]any
 
 	Enable     []string
 	Disable    []string
 	EnableAll  bool `mapstructure:"enable-all"`
 	DisableAll bool `mapstructure:"disable-all"`
+
+	// Deprecated: the linter should be enabled inside `Enable`.
+	CheckShadowing bool `mapstructure:"check-shadowing"`
 }
 
 func (cfg *GovetSettings) Validate() error {

pkg/config/loader.go

@@ -322,6 +322,12 @@ func (l *Loader) handleDeprecation() error {
 		l.cfg.Output.Formats = f
 	}
 
+	// Deprecated since v1.57.0,
+	// but it was unofficially deprecated since v1.19 (2019) (https://github.com/golangci/golangci-lint/pull/697).
+	if l.cfg.LintersSettings.Govet.CheckShadowing {
+		l.warn("The configuration option `govet.check-shadowing` is deprecated. Please enable `shadow` instead, if you are not using `enable-all`.")
+	}
+
 	return nil
 }