Skip to content

Packages with dir as "main" in package.json do not resolve. #3149

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zavr-1 opened this issue Nov 21, 2018 · 6 comments
Open

Packages with dir as "main" in package.json do not resolve. #3149

zavr-1 opened this issue Nov 21, 2018 · 6 comments
Assignees
Labels
triage-done Has been reviewed by someone on triage rotation.

Comments

@zavr-1
Copy link
Contributor

zavr-1 commented Nov 21, 2018

When trying to import a package that has a directory as its "main" field, there will be an error

example/example2.js:3: ERROR - Failed to load module "abc"
import abc from 'abc'
^
1 error(s), 0 warning(s)
node_modules
|-abc
  |-build
    -- index.js
  --package.json

cat package.json

{"name":"abc", "main":"build"}
@lauraharker
Copy link
Contributor

Filed internal Google bug b/119883741

@jplaisted
Copy link
Contributor

@ChadKillingsworth is this something you'd have time to look at?

@ChadKillingsworth
Copy link
Collaborator

Sure

@ChadKillingsworth ChadKillingsworth self-assigned this Nov 23, 2018
@zavr-1
Copy link
Contributor Author

zavr-1 commented Dec 4, 2018

??

@EatingW EatingW added the triage-done Has been reviewed by someone on triage rotation. label Dec 5, 2018
@EatingW
Copy link
Contributor

EatingW commented Dec 5, 2018

Created Google internal issue b/119883741

@ChadKillingsworth
Copy link
Collaborator

@zavr-1 It's going to be a bit before I can get to this. Webpack4 support is currently taking all my time.

@jplaisted jplaisted removed their assignment Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage-done Has been reviewed by someone on triage rotation.
Projects
None yet
Development

No branches or pull requests

5 participants