Skip to content

Commit 2a12ccd

Browse files
committed
Aligns other structs with the new convention
Required fields should be values, not pointers, because a lack of a value is an invalid specification.
1 parent 939e936 commit 2a12ccd

File tree

2 files changed

+12
-12
lines changed

2 files changed

+12
-12
lines changed

github/repos.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -523,12 +523,12 @@ type ProtectionRequest struct {
523523
// RequiredStatusChecks represents the protection status of a individual branch.
524524
type RequiredStatusChecks struct {
525525
// Enforce required status checks for repository administrators.
526-
IncludeAdmins *bool `json:"include_admins,omitempty"`
526+
IncludeAdmins bool `json:"include_admins"`
527527
// Require branches to be up to date before merging.
528-
Strict *bool `json:"strict,omitempty"`
528+
Strict bool `json:"strict"`
529529
// The list of status checks to require in order to merge into this
530530
// branch.
531-
Contexts *[]string `json:"contexts,omitempty"`
531+
Contexts []string `json:"contexts"`
532532
}
533533

534534
// RequiredPullRequestReviews represents the protection configuration for pull requests.

github/repos_test.go

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -491,9 +491,9 @@ func TestRepositoriesService_GetBranchProtection(t *testing.T) {
491491

492492
want := &Protection{
493493
RequiredStatusChecks: &RequiredStatusChecks{
494-
IncludeAdmins: Bool(true),
495-
Strict: Bool(true),
496-
Contexts: &[]string{"continuous-integration"},
494+
IncludeAdmins: true,
495+
Strict: true,
496+
Contexts: []string{"continuous-integration"},
497497
},
498498
RequiredPullRequestReviews: &RequiredPullRequestReviews{
499499
IncludeAdmins: true,
@@ -518,9 +518,9 @@ func TestRepositoriesService_UpdateBranchProtection(t *testing.T) {
518518

519519
input := &ProtectionRequest{
520520
RequiredStatusChecks: &RequiredStatusChecks{
521-
IncludeAdmins: Bool(true),
522-
Strict: Bool(true),
523-
Contexts: &[]string{"continuous-integration"},
521+
IncludeAdmins: true,
522+
Strict: true,
523+
Contexts: []string{"continuous-integration"},
524524
},
525525
RequiredPullRequestReviews: &RequiredPullRequestReviews{
526526
IncludeAdmins: true,
@@ -550,9 +550,9 @@ func TestRepositoriesService_UpdateBranchProtection(t *testing.T) {
550550

551551
want := &Protection{
552552
RequiredStatusChecks: &RequiredStatusChecks{
553-
IncludeAdmins: Bool(true),
554-
Strict: Bool(true),
555-
Contexts: &[]string{"continuous-integration"},
553+
IncludeAdmins: true,
554+
Strict: true,
555+
Contexts: []string{"continuous-integration"},
556556
},
557557
RequiredPullRequestReviews: &RequiredPullRequestReviews{
558558
IncludeAdmins: true,

0 commit comments

Comments
 (0)