Skip to content

Extending branch protection to include number of reviewers #879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
victoryNap opened this issue Mar 27, 2018 · 6 comments
Closed

Extending branch protection to include number of reviewers #879

victoryNap opened this issue Mar 27, 2018 · 6 comments

Comments

@victoryNap
Copy link
Contributor

Currently the PullRequestReviewsEnforcement struct doesn't contain the required_approving_review_count object that is available through the API. Working on a PR to add it.

https://github.com/google/go-github/blob/master/github/repos.go#L562-L568

https://developer.github.com/v3/repos/branches/#get-branch-protection

@victoryNap
Copy link
Contributor Author

victoryNap commented Mar 28, 2018

@gmlewis would you mind taking a look at this? Its pretty minor, but would be helpful.

@gmlewis
Copy link
Collaborator

gmlewis commented Mar 28, 2018

Thanks, @victoryNap. I commented on the PR.

@victoryNap
Copy link
Contributor Author

Reviewing and making changes now. Thanks for the feedback.

@victoryNap
Copy link
Contributor Author

@gmlewis @shurcooL When you get a minute, I've updated the PR for this.

@wesleimp
Copy link
Collaborator

wesleimp commented Dec 4, 2019

@gmlewis I think we can close this issue, right?

@gmlewis
Copy link
Collaborator

gmlewis commented Dec 4, 2019

Thank you, @wesleimp, I believe you are correct.

If anyone disagrees, feel free to reopen and explain why. Thanks.

Closing.

@gmlewis gmlewis closed this as completed Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants