Skip to content

[Feature Request] Support Branch protection for setting required_approving_review_count #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
majormoses opened this issue May 1, 2018 · 2 comments
Closed

[Feature Request] Support Branch protection for setting required_approving_review_count #905

majormoses opened this issue May 1, 2018 · 2 comments

Comments

@majormoses
Copy link

Per the rest api docs you can send required_approving_review_count as part of the required_pull_request_reviews object with an integer between 1-6 which represents the number of people required to approve the request in larger teams it is not uncommon to want more than a single approval before merging.

image
@majormoses majormoses mentioned this issue May 1, 2018
Closed
@victoryNap
Copy link
Contributor

I started the work on this but got side tracked. Will finish it up.

#880

@tadityar tadityar mentioned this issue Oct 8, 2018
Merged
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 8, 2018

Fixed by #880.
Closing.

@gmlewis gmlewis closed this as completed Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victoryNap @majormoses @gmlewis