Skip to content

Commit 8c0a26b

Browse files
kevinGCgvisor-bot
kevinGC
authored and
gvisor-bot
committed
netstack: make tcpip.Address hold a []byte
tcp_benchmark throughput increase 2-3%, but allocations go down (25% in the download benchmark, only 2% in the upload path). PiperOrigin-RevId: 525019419
1 parent 18a4f0c commit 8c0a26b

File tree

110 files changed

+1429
-1129
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

110 files changed

+1429
-1129
lines changed

‎pkg/sentry/socket/hostinet/netlink.go

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -284,21 +284,21 @@ func doNetlinkInterfaceRequest(typ, flags uint16, idx uint32, addr inet.Interfac
284284
Flags: addr.Flags,
285285
}
286286
// Local address.
287-
localAddr := tcpip.Address(addr.Addr)
287+
localAddr := tcpip.AddrFromSlice(addr.Addr)
288288
if addr.Family == linux.AF_INET {
289289
localAddr = localAddr.To4()
290290
}
291291
rtLocal := linux.RtAttr{
292-
Len: linux.SizeOfRtAttr + uint16(len(localAddr)),
292+
Len: linux.SizeOfRtAttr + uint16(localAddr.Len()),
293293
Type: linux.IFA_LOCAL,
294294
}
295-
localAddrBs := primitive.ByteSlice(localAddr)
295+
localAddrBs := primitive.ByteSlice(localAddr.AsSlice())
296296
// Peer is always the local address for us.
297297
rtPeer := linux.RtAttr{
298-
Len: linux.SizeOfRtAttr + uint16(len(localAddr)),
298+
Len: linux.SizeOfRtAttr + uint16(localAddr.Len()),
299299
Type: linux.IFA_ADDRESS,
300300
}
301-
peerAddrBs := primitive.ByteSlice(localAddr)
301+
peerAddrBs := primitive.ByteSlice(localAddr.AsSlice())
302302

303303
msgs := []marshal.Marshallable{
304304
&hdr,

‎pkg/sentry/socket/netfilter/ipv4.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ import (
2828
// emptyIPv4Filter is for comparison with a rule's filters to determine whether
2929
// it is also empty. It is immutable.
3030
var emptyIPv4Filter = stack.IPHeaderFilter{
31-
Dst: "\x00\x00\x00\x00",
32-
DstMask: "\x00\x00\x00\x00",
33-
Src: "\x00\x00\x00\x00",
34-
SrcMask: "\x00\x00\x00\x00",
31+
Dst: tcpip.AddrFrom4([4]byte{0x00, 0x00, 0x00, 0x00}),
32+
DstMask: tcpip.AddrFrom4([4]byte{0x00, 0x00, 0x00, 0x00}),
33+
Src: tcpip.AddrFrom4([4]byte{0x00, 0x00, 0x00, 0x00}),
34+
SrcMask: tcpip.AddrFrom4([4]byte{0x00, 0x00, 0x00, 0x00}),
3535
}
3636

3737
// convertNetstackToBinary4 converts the iptables as stored in netstack to the
@@ -75,10 +75,10 @@ func getEntries4(table stack.Table, tablename linux.TableName) (linux.KernelIPTG
7575
TargetOffset: linux.SizeOfIPTEntry,
7676
},
7777
}
78-
copy(entry.Entry.IP.Dst[:], rule.Filter.Dst)
79-
copy(entry.Entry.IP.DstMask[:], rule.Filter.DstMask)
80-
copy(entry.Entry.IP.Src[:], rule.Filter.Src)
81-
copy(entry.Entry.IP.SrcMask[:], rule.Filter.SrcMask)
78+
copy(entry.Entry.IP.Dst[:], rule.Filter.Dst.AsSlice())
79+
copy(entry.Entry.IP.DstMask[:], rule.Filter.DstMask.AsSlice())
80+
copy(entry.Entry.IP.Src[:], rule.Filter.Src.AsSlice())
81+
copy(entry.Entry.IP.SrcMask[:], rule.Filter.SrcMask.AsSlice())
8282
copy(entry.Entry.IP.OutputInterface[:], rule.Filter.OutputInterface)
8383
copy(entry.Entry.IP.OutputInterfaceMask[:], rule.Filter.OutputInterfaceMask)
8484
copy(entry.Entry.IP.InputInterface[:], rule.Filter.InputInterface)
@@ -218,11 +218,11 @@ func filterFromIPTIP(iptip linux.IPTIP) (stack.IPHeaderFilter, error) {
218218
Protocol: tcpip.TransportProtocolNumber(iptip.Protocol),
219219
// A Protocol value of 0 indicates all protocols match.
220220
CheckProtocol: iptip.Protocol != 0,
221-
Dst: tcpip.Address(iptip.Dst[:]),
222-
DstMask: tcpip.Address(iptip.DstMask[:]),
221+
Dst: tcpip.AddrFrom4(iptip.Dst),
222+
DstMask: tcpip.AddrFrom4(iptip.DstMask),
223223
DstInvert: iptip.InverseFlags&linux.IPT_INV_DSTIP != 0,
224-
Src: tcpip.Address(iptip.Src[:]),
225-
SrcMask: tcpip.Address(iptip.SrcMask[:]),
224+
Src: tcpip.AddrFrom4(iptip.Src),
225+
SrcMask: tcpip.AddrFrom4(iptip.SrcMask),
226226
SrcInvert: iptip.InverseFlags&linux.IPT_INV_SRCIP != 0,
227227
InputInterface: string(trimNullBytes(iptip.InputInterface[:])),
228228
InputInterfaceMask: string(trimNullBytes(iptip.InputInterfaceMask[:])),

‎pkg/sentry/socket/netfilter/ipv6.go

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,10 @@ import (
2828
// emptyIPv6Filter is for comparison with a rule's filters to determine whether
2929
// it is also empty. It is immutable.
3030
var emptyIPv6Filter = stack.IPHeaderFilter{
31-
Dst: "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
32-
DstMask: "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
33-
Src: "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
34-
SrcMask: "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00",
31+
Dst: tcpip.AddrFrom16([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}),
32+
DstMask: tcpip.AddrFrom16([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}),
33+
Src: tcpip.AddrFrom16([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}),
34+
SrcMask: tcpip.AddrFrom16([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}),
3535
}
3636

3737
// convertNetstackToBinary6 converts the ip6tables as stored in netstack to the
@@ -75,10 +75,10 @@ func getEntries6(table stack.Table, tablename linux.TableName) (linux.KernelIP6T
7575
TargetOffset: linux.SizeOfIP6TEntry,
7676
},
7777
}
78-
copy(entry.Entry.IPv6.Dst[:], rule.Filter.Dst)
79-
copy(entry.Entry.IPv6.DstMask[:], rule.Filter.DstMask)
80-
copy(entry.Entry.IPv6.Src[:], rule.Filter.Src)
81-
copy(entry.Entry.IPv6.SrcMask[:], rule.Filter.SrcMask)
78+
copy(entry.Entry.IPv6.Dst[:], rule.Filter.Dst.AsSlice())
79+
copy(entry.Entry.IPv6.DstMask[:], rule.Filter.DstMask.AsSlice())
80+
copy(entry.Entry.IPv6.Src[:], rule.Filter.Src.AsSlice())
81+
copy(entry.Entry.IPv6.SrcMask[:], rule.Filter.SrcMask.AsSlice())
8282
copy(entry.Entry.IPv6.OutputInterface[:], rule.Filter.OutputInterface)
8383
copy(entry.Entry.IPv6.OutputInterfaceMask[:], rule.Filter.OutputInterfaceMask)
8484
copy(entry.Entry.IPv6.InputInterface[:], rule.Filter.InputInterface)
@@ -221,11 +221,11 @@ func filterFromIP6TIP(iptip linux.IP6TIP) (stack.IPHeaderFilter, error) {
221221
Protocol: tcpip.TransportProtocolNumber(iptip.Protocol),
222222
// In ip6tables a flag controls whether to check the protocol.
223223
CheckProtocol: iptip.Flags&linux.IP6T_F_PROTO != 0,
224-
Dst: tcpip.Address(iptip.Dst[:]),
225-
DstMask: tcpip.Address(iptip.DstMask[:]),
224+
Dst: tcpip.AddrFrom16(iptip.Dst),
225+
DstMask: tcpip.AddrFrom16(iptip.DstMask),
226226
DstInvert: iptip.InverseFlags&linux.IP6T_INV_DSTIP != 0,
227-
Src: tcpip.Address(iptip.Src[:]),
228-
SrcMask: tcpip.Address(iptip.SrcMask[:]),
227+
Src: tcpip.AddrFrom16(iptip.Src),
228+
SrcMask: tcpip.AddrFrom16(iptip.SrcMask),
229229
SrcInvert: iptip.InverseFlags&linux.IP6T_INV_SRCIP != 0,
230230
InputInterface: string(trimNullBytes(iptip.InputInterface[:])),
231231
InputInterfaceMask: string(trimNullBytes(iptip.InputInterfaceMask[:])),

‎pkg/sentry/socket/netfilter/targets.go

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ func (*redirectTargetMaker) unmarshal(buf []byte, filter stack.IPHeaderFilter) (
346346
return nil, syserr.ErrInvalidArgument
347347
}
348348

349-
target.addr = tcpip.Address(nfRange.RangeIPV4.MinIP[:])
349+
target.addr = tcpip.AddrFrom4(nfRange.RangeIPV4.MinIP)
350350
target.Port = ntohs(nfRange.RangeIPV4.MinPort)
351351

352352
return &target, nil
@@ -382,8 +382,8 @@ func (*nfNATTargetMaker) marshal(target target) []byte {
382382
},
383383
}
384384
copy(nt.Target.Name[:], RedirectTargetName)
385-
copy(nt.Range.MinAddr[:], rt.addr)
386-
copy(nt.Range.MaxAddr[:], rt.addr)
385+
copy(nt.Range.MinAddr[:], rt.addr.AsSlice())
386+
copy(nt.Range.MaxAddr[:], rt.addr.AsSlice())
387387

388388
nt.Range.MinProto = htons(rt.Port)
389389
nt.Range.MaxProto = nt.Range.MinProto
@@ -426,7 +426,7 @@ func (*nfNATTargetMaker) unmarshal(buf []byte, filter stack.IPHeaderFilter) (tar
426426
NetworkProtocol: filter.NetworkProtocol(),
427427
Port: ntohs(natRange.MinProto),
428428
},
429-
addr: tcpip.Address(natRange.MinAddr[:]),
429+
addr: tcpip.AddrFrom16(natRange.MinAddr),
430430
}
431431

432432
return &target, nil
@@ -457,8 +457,8 @@ func (*snatTargetMakerV4) marshal(target target) []byte {
457457
xt.NfRange.RangeIPV4.Flags |= linux.NF_NAT_RANGE_MAP_IPS | linux.NF_NAT_RANGE_PROTO_SPECIFIED
458458
xt.NfRange.RangeIPV4.MinPort = htons(st.Port)
459459
xt.NfRange.RangeIPV4.MaxPort = xt.NfRange.RangeIPV4.MinPort
460-
copy(xt.NfRange.RangeIPV4.MinIP[:], st.Addr)
461-
copy(xt.NfRange.RangeIPV4.MaxIP[:], st.Addr)
460+
copy(xt.NfRange.RangeIPV4.MinIP[:], st.Addr.AsSlice())
461+
copy(xt.NfRange.RangeIPV4.MaxIP[:], st.Addr.AsSlice())
462462
return marshal.Marshal(&xt)
463463
}
464464

@@ -504,7 +504,7 @@ func (*snatTargetMakerV4) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta
504504
return nil, syserr.ErrInvalidArgument
505505
}
506506

507-
target.Addr = tcpip.Address(nfRange.RangeIPV4.MinIP[:])
507+
target.Addr = tcpip.AddrFrom4(nfRange.RangeIPV4.MinIP)
508508
target.Port = ntohs(nfRange.RangeIPV4.MinPort)
509509

510510
return &target, nil
@@ -533,8 +533,8 @@ func (*snatTargetMakerV6) marshal(target target) []byte {
533533
},
534534
}
535535
copy(nt.Target.Name[:], SNATTargetName)
536-
copy(nt.Range.MinAddr[:], st.Addr)
537-
copy(nt.Range.MaxAddr[:], st.Addr)
536+
copy(nt.Range.MinAddr[:], st.Addr.AsSlice())
537+
copy(nt.Range.MaxAddr[:], st.Addr.AsSlice())
538538
nt.Range.MinProto = htons(st.Port)
539539
nt.Range.MaxProto = nt.Range.MinProto
540540

@@ -574,7 +574,7 @@ func (*snatTargetMakerV6) unmarshal(buf []byte, filter stack.IPHeaderFilter) (ta
574574
target := snatTarget{
575575
SNATTarget: stack.SNATTarget{
576576
NetworkProtocol: filter.NetworkProtocol(),
577-
Addr: tcpip.Address(natRange.MinAddr[:]),
577+
Addr: tcpip.AddrFrom16(natRange.MinAddr),
578578
Port: ntohs(natRange.MinProto),
579579
},
580580
}

‎pkg/sentry/socket/netstack/netstack.go

Lines changed: 13 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -666,8 +666,8 @@ func (s *sock) checkFamily(family uint16, exact bool) bool {
666666
//
667667
// TODO(gvisor.dev/issue/1556): remove this function.
668668
func (s *sock) mapFamily(addr tcpip.FullAddress, family uint16) tcpip.FullAddress {
669-
if len(addr.Addr) == 0 && s.family == linux.AF_INET6 && family == linux.AF_INET {
670-
addr.Addr = "\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\xff\xff\x00\x00\x00\x00"
669+
if addr.Addr.BitLen() == 0 && s.family == linux.AF_INET6 && family == linux.AF_INET {
670+
addr.Addr = tcpip.AddrFrom16([16]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0xff, 0xff, 0x00, 0x00, 0x00, 0x00})
671671
}
672672
return addr
673673
}
@@ -748,8 +748,11 @@ func (s *sock) Bind(_ *kernel.Task, sockaddr []byte) *syserr.Error {
748748
a.UnmarshalBytes(sockaddr)
749749

750750
addr = tcpip.FullAddress{
751-
NIC: tcpip.NICID(a.InterfaceIndex),
752-
Addr: tcpip.Address(a.HardwareAddr[:header.EthernetAddressSize]),
751+
NIC: tcpip.NICID(a.InterfaceIndex),
752+
Addr: tcpip.AddrFrom16Slice(append(
753+
a.HardwareAddr[:header.EthernetAddressSize],
754+
[]byte{0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00}...,
755+
)),
753756
Port: socket.Ntohs(a.Protocol),
754757
}
755758
} else {
@@ -2181,7 +2184,7 @@ func setSockOptIPv6(t *kernel.Task, s socket.Socket, ep commonEndpoint, name int
21812184

21822185
return syserr.TranslateNetstackError(ep.SetSockOpt(&tcpip.AddMembershipOption{
21832186
NIC: tcpip.NICID(req.InterfaceIndex),
2184-
MulticastAddr: tcpip.Address(req.MulticastAddr[:]),
2187+
MulticastAddr: tcpip.AddrFrom16(req.MulticastAddr),
21852188
}))
21862189

21872190
case linux.IPV6_DROP_MEMBERSHIP:
@@ -2192,7 +2195,7 @@ func setSockOptIPv6(t *kernel.Task, s socket.Socket, ep commonEndpoint, name int
21922195

21932196
return syserr.TranslateNetstackError(ep.SetSockOpt(&tcpip.RemoveMembershipOption{
21942197
NIC: tcpip.NICID(req.InterfaceIndex),
2195-
MulticastAddr: tcpip.Address(req.MulticastAddr[:]),
2198+
MulticastAddr: tcpip.AddrFrom16(req.MulticastAddr),
21962199
}))
21972200

21982201
case linux.IPV6_IPSEC_POLICY,
@@ -2399,8 +2402,8 @@ func setSockOptIP(t *kernel.Task, s socket.Socket, ep commonEndpoint, name int,
23992402
NIC: tcpip.NICID(req.InterfaceIndex),
24002403
// TODO(igudger): Change AddMembership to use the standard
24012404
// any address representation.
2402-
InterfaceAddr: tcpip.Address(req.InterfaceAddr[:]),
2403-
MulticastAddr: tcpip.Address(req.MulticastAddr[:]),
2405+
InterfaceAddr: tcpip.AddrFrom4(req.InterfaceAddr),
2406+
MulticastAddr: tcpip.AddrFrom4(req.MulticastAddr),
24042407
}))
24052408

24062409
case linux.IP_DROP_MEMBERSHIP:
@@ -2413,8 +2416,8 @@ func setSockOptIP(t *kernel.Task, s socket.Socket, ep commonEndpoint, name int,
24132416
NIC: tcpip.NICID(req.InterfaceIndex),
24142417
// TODO(igudger): Change DropMembership to use the standard
24152418
// any address representation.
2416-
InterfaceAddr: tcpip.Address(req.InterfaceAddr[:]),
2417-
MulticastAddr: tcpip.Address(req.MulticastAddr[:]),
2419+
InterfaceAddr: tcpip.AddrFrom4(req.InterfaceAddr),
2420+
MulticastAddr: tcpip.AddrFrom4(req.MulticastAddr),
24182421
}))
24192422

24202423
case linux.IP_MULTICAST_IF:

‎pkg/sentry/socket/netstack/stack.go

Lines changed: 12 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -117,10 +117,11 @@ func (s *Stack) InterfaceAddrs() map[int32][]inet.InterfaceAddr {
117117
continue
118118
}
119119

120+
addrCopy := a.AddressWithPrefix.Address
120121
addrs = append(addrs, inet.InterfaceAddr{
121122
Family: family,
122123
PrefixLen: uint8(a.AddressWithPrefix.PrefixLen),
123-
Addr: []byte(a.AddressWithPrefix.Address),
124+
Addr: addrCopy.AsSlice(),
124125
// TODO(b/68878065): Other fields.
125126
})
126127
}
@@ -145,7 +146,7 @@ func convertAddr(addr inet.InterfaceAddr) (tcpip.ProtocolAddress, error) {
145146
return protocolAddress, linuxerr.EINVAL
146147
}
147148
protocol = ipv4.ProtocolNumber
148-
address = tcpip.Address(addr.Addr)
149+
address = tcpip.AddrFrom4Slice(addr.Addr)
149150
case linux.AF_INET6:
150151
if len(addr.Addr) != header.IPv6AddressSize {
151152
return protocolAddress, linuxerr.EINVAL
@@ -154,7 +155,7 @@ func convertAddr(addr inet.InterfaceAddr) (tcpip.ProtocolAddress, error) {
154155
return protocolAddress, linuxerr.EINVAL
155156
}
156157
protocol = ipv6.ProtocolNumber
157-
address = tcpip.Address(addr.Addr)
158+
address = tcpip.AddrFrom16Slice(addr.Addr)
158159
default:
159160
return protocolAddress, linuxerr.ENOTSUP
160161
}
@@ -185,7 +186,7 @@ func (s *Stack) AddInterfaceAddr(idx int32, addr inet.InterfaceAddr) error {
185186
// Add route for local network if it doesn't exist already.
186187
localRoute := tcpip.Route{
187188
Destination: protocolAddress.AddressWithPrefix.Subnet(),
188-
Gateway: "", // No gateway for local network.
189+
Gateway: tcpip.Address{}, // No gateway for local network.
189190
NIC: nicID,
190191
}
191192

@@ -217,7 +218,7 @@ func (s *Stack) RemoveInterfaceAddr(idx int32, addr inet.InterfaceAddr) error {
217218
// Remove the corresponding local network route if it exists.
218219
localRoute := tcpip.Route{
219220
Destination: protocolAddress.AddressWithPrefix.Subnet(),
220-
Gateway: "", // No gateway for local network.
221+
Gateway: tcpip.Address{}, // No gateway for local network.
221222
NIC: nicID,
222223
}
223224
s.Stack.RemoveRoutes(func(rt tcpip.Route) bool {
@@ -430,16 +431,17 @@ func (s *Stack) RouteTable() []inet.Route {
430431

431432
for _, rt := range s.Stack.GetRouteTable() {
432433
var family uint8
433-
switch len(rt.Destination.ID()) {
434-
case header.IPv4AddressSize:
434+
switch rt.Destination.ID().BitLen() {
435+
case header.IPv4AddressSizeBits:
435436
family = linux.AF_INET
436-
case header.IPv6AddressSize:
437+
case header.IPv6AddressSizeBits:
437438
family = linux.AF_INET6
438439
default:
439440
log.Warningf("Unknown network protocol in route %+v", rt)
440441
continue
441442
}
442443

444+
dstAddr := rt.Destination.ID()
443445
routeTable = append(routeTable, inet.Route{
444446
Family: family,
445447
DstLen: uint8(rt.Destination.Prefix()), // The CIDR prefix for the destination.
@@ -453,9 +455,9 @@ func (s *Stack) RouteTable() []inet.Route {
453455
Scope: linux.RT_SCOPE_LINK,
454456
Type: linux.RTN_UNICAST,
455457

456-
DstAddr: []byte(rt.Destination.ID()),
458+
DstAddr: dstAddr.AsSlice(),
457459
OutputInterface: int32(rt.NIC),
458-
GatewayAddr: []byte(rt.Gateway),
460+
GatewayAddr: rt.Gateway.AsSlice(),
459461
})
460462
}
461463

0 commit comments

Comments
 (0)