Skip to content

Commit b0939b1

Browse files
authored
Update Neutral Lighting environment (aesthetics) (#2249)
* update neutral lighting to reduce huge specular on top of the object * update -x side to adjust light value compatible to the rest * adjust +X to bring the lighting value to conformity * Update EvironmentSceneAlt.ts add description on +x
1 parent 6a70645 commit b0939b1

File tree

1 file changed

+32
-19
lines changed

1 file changed

+32
-19
lines changed

packages/model-viewer/src/three-components/EvironmentSceneAlt.ts

Lines changed: 32 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ export default class EnvironmentSceneAlt extends Scene {
2828
new MeshStandardMaterial({metalness: 0, side: BackSide});
2929
const boxMaterial = new MeshStandardMaterial({metalness: 0});
3030

31-
const mainLight = new PointLight(0xffffff, 500.0, 28, 2);
32-
mainLight.position.set(0.5, 16.5, 0.5);
31+
const mainLight = new PointLight(0xffffff, 400.0, 28, 2);
32+
mainLight.position.set(0.5, 14.0, 0.5);
3333
this.add(mainLight);
3434

3535
const room = new Mesh(geometry, roomMaterial);
@@ -73,36 +73,49 @@ export default class EnvironmentSceneAlt extends Scene {
7373
box6.scale.set(3.875, 3.487, 2.986);
7474
this.add(box6);
7575

76-
77-
// -x
78-
const light1 = new Mesh(geometry, this.createAreaLightMaterial(18));
79-
light1.position.set(-14.0, 9.0, 0.1);
80-
light1.scale.set(0.1, 5.0, 5.0);
76+
// -x_left
77+
const light1 = new Mesh(geometry, this.createAreaLightMaterial(80));
78+
light1.position.set(-14.0, 10.0, 8.0);
79+
light1.scale.set(0.1, 2.5, 2.5);
8180
this.add(light1);
8281

83-
// +x
84-
const light3 = new Mesh(geometry, this.createAreaLightMaterial(18));
85-
light3.position.set(14.0, 9.0, 0.1);
82+
// -x_right
83+
const light2 = new Mesh(geometry, this.createAreaLightMaterial(80));
84+
light2.position.set(-14.0, 14.0, -4.0);
85+
light2.scale.set(0.1, 2.5, 2.5);
86+
this.add(light2);
87+
88+
89+
90+
// +x only on light
91+
const light3 = new Mesh(geometry, this.createAreaLightMaterial(23));
92+
light3.position.set(14.0, 12.0, 0.0);
8693
light3.scale.set(0.1, 5.0, 5.0);
8794
this.add(light3);
8895

8996
// +z
90-
const light4 = new Mesh(geometry, this.createAreaLightMaterial(18));
97+
const light4 = new Mesh(geometry, this.createAreaLightMaterial(16));
9198
light4.position.set(0.0, 9.0, 14.0);
9299
light4.scale.set(5.0, 5.0, 0.1);
93100
this.add(light4);
94101

95-
// -z
96-
const light5 = new Mesh(geometry, this.createAreaLightMaterial(18));
97-
light5.position.set(0, 9.0, -14.0);
98-
light5.scale.set(5.0, 5.0, 0.1);
102+
// -z right
103+
const light5 = new Mesh(geometry, this.createAreaLightMaterial(80));
104+
light5.position.set(7.0, 8.0, -14.0);
105+
light5.scale.set(2.5, 2.5, 0.1);
99106
this.add(light5);
100107

101-
// +y
102-
const light6 = new Mesh(geometry, this.createAreaLightMaterial(18));
103-
light6.position.set(0.0, 20.0, 0.0);
104-
light6.scale.set(1.5, 0.1, 1.5);
108+
// -z left
109+
const light6 = new Mesh(geometry, this.createAreaLightMaterial(80));
110+
light6.position.set(-7.0, 16.0, -14.0);
111+
light6.scale.set(2.5, 2.5, 0.1);
105112
this.add(light6);
113+
114+
// +y
115+
const light7 = new Mesh(geometry, this.createAreaLightMaterial(1));
116+
light7.position.set(0.0, 20.0, 0.0);
117+
light7.scale.set(0.1, 0.1, 0.1);
118+
this.add(light7);
106119
}
107120

108121
createAreaLightMaterial(intensity: number): MeshBasicMaterial {

0 commit comments

Comments
 (0)