Skip to content

Traceur/Atscript - annotations vs annotate #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hannahhoward opened this issue Jan 17, 2015 · 5 comments
Closed

Traceur/Atscript - annotations vs annotate #1642

hannahhoward opened this issue Jan 17, 2015 · 5 comments

Comments

@hannahhoward
Copy link

When Traceur compiles annotations, they become a .annotations property on the object they annotate. However, the AtScript specification, or at least the AtScript Primer, which is the top Google hit when you search for AtScript specification, says the property should be called .annotate:
https://docs.google.com/document/d/11YUzC-1d0V1-Q3V0fQ7KSit97HnZoKVygDxpWzEYW0U/mobilebasic?viewopt=127

Should these be brought into sync in some fashion? Which is correct for AtScript? It's very confusing.

Also, it looks like TypeScript is looking at Annotations based off the .annotate property mentioned in the AtScript primer. microsoft/TypeScript#1557

@JeroMiya
Copy link

Thanks for fixing this! As you say, I based it off of the primer.

As an aside, there is some discussion in the referenced TypeScript issue regarding decorators vs. annotations, with some leaning towards decorators. Would anyone on the traceur team care to chime in on that discussion - perhaps explaining why traceur chose annotations over decorators?

@arv
Copy link
Collaborator

arv commented Jan 18, 2015

I'm not sure about this. The annotations feature was added by the Angular team. If they want to change the name of the property I'm fine with that but the option name should still be annotations for consistency.

@vojtajina

@hannahhoward
Copy link
Author

yep I'm just trying to bring it in line with the published docs on AtScript, which I think the Angular team created. Honestly, it's early enough that either is probably fine, just wanted to call attention to the inconsistency. Maybe it makes better sense to just fix the docs.

@matjaz
Copy link

matjaz commented Feb 3, 2015

yeah. The same goes to parameters array of arrays vs. [{is, annotate:[]}]

see aurelia/dependency-injection#16

@arv
Copy link
Collaborator

arv commented Mar 3, 2015

I'm going to close this bug until I hear from @mhevery or @IgorMinar.

@arv arv closed this as completed Mar 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants