-
Notifications
You must be signed in to change notification settings - Fork 579
Traceur/Atscript - annotations vs annotate #1642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thanks for fixing this! As you say, I based it off of the primer. As an aside, there is some discussion in the referenced TypeScript issue regarding decorators vs. annotations, with some leaning towards decorators. Would anyone on the traceur team care to chime in on that discussion - perhaps explaining why traceur chose annotations over decorators? |
I'm not sure about this. The annotations feature was added by the Angular team. If they want to change the name of the property I'm fine with that but the option name should still be annotations for consistency. |
yep I'm just trying to bring it in line with the published docs on AtScript, which I think the Angular team created. Honestly, it's early enough that either is probably fine, just wanted to call attention to the inconsistency. Maybe it makes better sense to just fix the docs. |
yeah. The same goes to |
I'm going to close this bug until I hear from @mhevery or @IgorMinar. |
When Traceur compiles annotations, they become a .annotations property on the object they annotate. However, the AtScript specification, or at least the AtScript Primer, which is the top Google hit when you search for AtScript specification, says the property should be called .annotate:
https://docs.google.com/document/d/11YUzC-1d0V1-Q3V0fQ7KSit97HnZoKVygDxpWzEYW0U/mobilebasic?viewopt=127
Should these be brought into sync in some fashion? Which is correct for AtScript? It's very confusing.
Also, it looks like TypeScript is looking at Annotations based off the .annotate property mentioned in the AtScript primer. microsoft/TypeScript#1557
The text was updated successfully, but these errors were encountered: