Skip to content

ENH: restrict to Python 3.5 and higher in setup.py #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nicoa opened this issue Dec 23, 2019 · 4 comments · Fixed by #314
Closed

ENH: restrict to Python 3.5 and higher in setup.py #306

nicoa opened this issue Dec 23, 2019 · 4 comments · Fixed by #314
Labels
accepting pull requests type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@nicoa
Copy link
Contributor

nicoa commented Dec 23, 2019

Some Foreword: please ask me for further information/MWE if necessary, I hope it will be understandable without for now:

We expercienced some error like the following:

MYENV/local/lib/python2.7/site-packages/pandas/io/common.pyc in writerows(self, rows)
    549             data = self.encoder.encode(data)
    550             # write to the target stream
--> 551             self.stream.write(data)
    552             # empty queue
    553             self.queue.truncate(0)

TypeError: unicode argument expected, got 'str'

This seems to appear in version 0.13.0, pinning back to 0.12.0 seems to work.

Still, referring to the changelog they are both not supported under python 2 (under which this occurred). Is it expected behaviour they get still installed? Is this a problem on pypi side or can it be fixed on the package site?

Thanks for your efforts!

@tswast
Copy link
Collaborator

tswast commented Dec 23, 2019

I thought that removing Python 2 from the classifiers and removing the "universal" mark in the manifest would be sufficient (#273) but maybe there's something else we need to do?

@tswast
Copy link
Collaborator

tswast commented Dec 23, 2019

What commands are you using to install the package?

@nicoa
Copy link
Contributor Author

nicoa commented Dec 23, 2019

Regarding the commands used: I'm not sure since with no access to it right now, but with rather high probability we install this from a requirements file to some virtualenv using pip. Will update later these days as soon as having access again.

@tswast tswast closed this as completed Feb 7, 2020
@tswast tswast reopened this Feb 13, 2020
@tswast
Copy link
Collaborator

tswast commented Feb 13, 2020

Looks like there's a python_requires we can add to setup.py. https://stackoverflow.com/a/45362425/101923 (docs: https://packaging.python.org/guides/distributing-packages-using-setuptools/#python-requires)

I believe we support Python 3.5 and higher.

@tswast tswast added accepting pull requests type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Feb 13, 2020
@tswast tswast changed the title python2 still installs new versions ENH: restrict to Python 3.5 and higher in setup.py Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepting pull requests type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants