Fix index access panic (#74)

julienduchesne · web-flow · commit 7938ac0b6bc4 · 2022-09-12T15:31:29.000-04:00
* Fix index access panic
Oops, the second "if" crashes

* Remove empty line
diff --git a/pkg/server/server.go b/pkg/server/server.go
@@ -93,10 +93,7 @@ func (s *Server) DidChange(ctx context.Context, params *protocol.DidChangeTextDo
 			splitOldText := strings.Split(oldText, "\n")
 			splitNewText := strings.Split(doc.item.Text, "\n")
 			for index, oldLine := range splitOldText {
-				if index >= len(splitNewText) {
-					doc.linesChangedSinceAST[index] = true
-				}
-				if oldLine != splitNewText[index] {
+				if index >= len(splitNewText) || oldLine != splitNewText[index] {
 					doc.linesChangedSinceAST[index] = true
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -93,10 +93,7 @@ func (s Server) DidChange(ctx context.Context, params protocol.DidChangeTextDo`
`93`	`93`	`splitOldText := strings.Split(oldText, "\n")`
`94`	`94`	`splitNewText := strings.Split(doc.item.Text, "\n")`
`95`	`95`	`for index, oldLine := range splitOldText {`
`96`		`- if index >= len(splitNewText) {`
`97`		`- doc.linesChangedSinceAST[index] = true`
`98`		`- }`
`99`		`- if oldLine != splitNewText[index] {`
	`96`	`+ if index >= len(splitNewText) \|\| oldLine != splitNewText[index] {`
`100`	`97`	`doc.linesChangedSinceAST[index] = true`
`101`	`98`	`}`
`102`	`99`	`}`