You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
* Fix world's slowest stack overflow
When dealing with CRDsonnet libraries in our (Grafana Labs) repositories, the language server would lock up:
- I thought it had something to do with CRDsonnet but I was wrong.
- This happened because it was trying to find a field in the wrong nodestack repeatedly (see image)
- This PR fixes the issue.
- Obviously, the language server can't find fields that come from processing jsonschema, but at least it doesn't take up 4 full CPUs (it reached a full 1% CPU usage while testing :) )
* Remove unneeded boolean
All tests are still passing. `$` can be resolved across multiple files, so I guess the language server is just better now and doesn't need that safety
If this causes a bug, we should add a new test
0 commit comments