nativeClassicSumBy: format list of labels nicer (#1204)

krajorama · web-flow · commit 3288dff1e880 · 2024-04-24T15:53:41.000+02:00
Otherwise I get a bigger diff in a dependent issue.

Signed-off-by: György Krajcsovits &lt;gyorgy.krajcsovits@grafana.com&gt;
diff --git a/mixin-utils/utils.libsonnet b/mixin-utils/utils.libsonnet
@@ -111,7 +111,7 @@ local g = import 'grafana-builder/grafana.libsonnet';
     },
 
   nativeClassicSumBy(query, sum_by=[], multiplier='')::
-    local sumBy = if std.length(sum_by) > 0 then ' by (%(lbls)s) ' % { lbls: std.join(',', sum_by) } else ' ';
+    local sumBy = if std.length(sum_by) > 0 then ' by (%(lbls)s) ' % { lbls: std.join(', ', sum_by) } else ' ';
     local multiplierStr = if multiplier == '' then '' else ' * %s' % multiplier;
     {
       classic: 'sum%(sumBy)s(%(query)s)%(multiplierStr)s' % {

Original file line number	Diff line number	Diff line change
`@@ -111,7 +111,7 @@ local g = import 'grafana-builder/grafana.libsonnet';`
`111`	`111`	`},`
`112`	`112`
`113`	`113`	`nativeClassicSumBy(query, sum_by=[], multiplier='')::`
`114`		`- local sumBy = if std.length(sum_by) > 0 then ' by (%(lbls)s) ' % { lbls: std.join(',', sum_by) } else ' ';`
	`114`	`+ local sumBy = if std.length(sum_by) > 0 then ' by (%(lbls)s) ' % { lbls: std.join(', ', sum_by) } else ' ';`
`115`	`115`	`local multiplierStr = if multiplier == '' then '' else ' * %s' % multiplier;`
`116`	`116`	`{`
`117`	`117`	`classic: 'sum%(sumBy)s(%(query)s)%(multiplierStr)s' % {`