Skip to content

Commit 80dae07

Browse files
committed
Mixins: draw graphs at full resolution
Remove "intervalFactor: 2", which corresponded to "Resolution 1/2" in the Grafana UI. This feature has now been dropped from the UI, and I can't see why were ever using it - why would you not want the full resolution for your panels? Left `awx-mixin/dashboards/clustertable.libsonnet` untouched because those are table queries not timeseries.
1 parent f56b211 commit 80dae07

File tree

4 files changed

+0
-13
lines changed

4 files changed

+0
-13
lines changed

envoy-mixin/dashboards.libsonnet

-1
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,6 @@ local template = import 'grafonnet/template.libsonnet';
134134
{
135135
expr: 'sum by (status) (label_replace(rate(' + selector + '[$__rate_interval]), "status", "${1}xx", "envoy_response_code_class", "(.*)"))',
136136
format: 'time_series',
137-
intervalFactor: 2,
138137
legendFormat: '{{status}}',
139138
refId: 'A',
140139
step: 10,

grafana-builder/grafana.libsonnet

-7
Original file line numberDiff line numberDiff line change
@@ -289,7 +289,6 @@
289289
legendLink: legendLink,
290290
expr: ql.q,
291291
format: 'time_series',
292-
intervalFactor: 2,
293292
legendFormat: ql.l,
294293
}
295294
for ql in qsandls
@@ -305,7 +304,6 @@
305304
expr: query,
306305
format: 'time_series',
307306
instant: true,
308-
intervalFactor: 2,
309307
refId: 'A',
310308
},
311309
],
@@ -368,7 +366,6 @@
368366
expr: qs[i],
369367
format: 'table',
370368
instant: true,
371-
intervalFactor: 2,
372369
legendFormat: '',
373370
refId: std.char(65 + i),
374371
}
@@ -445,7 +442,6 @@
445442
"status", "${1}", "%s", "([a-zA-Z]+)"))
446443
||| % [selector, statusLabelName, statusLabelName],
447444
format: 'time_series',
448-
intervalFactor: 2,
449445
legendFormat: '{{status}}',
450446
refId: 'A',
451447
},
@@ -458,21 +454,18 @@
458454
{
459455
expr: 'histogram_quantile(0.99, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
460456
format: 'time_series',
461-
intervalFactor: 2,
462457
legendFormat: '99th Percentile',
463458
refId: 'A',
464459
},
465460
{
466461
expr: 'histogram_quantile(0.50, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
467462
format: 'time_series',
468-
intervalFactor: 2,
469463
legendFormat: '50th Percentile',
470464
refId: 'B',
471465
},
472466
{
473467
expr: 'sum(rate(%s_sum%s[$__rate_interval])) * %s / sum(rate(%s_count%s[$__rate_interval]))' % [metricName, selector, multiplier, metricName, selector],
474468
format: 'time_series',
475-
intervalFactor: 2,
476469
legendFormat: 'Average',
477470
refId: 'C',
478471
},

jaeger-mixin/dashboards.libsonnet

-2
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,13 @@ local g = (import 'grafana-builder/grafana.libsonnet') + {
1010
{
1111
expr: expr(selectorErr),
1212
format: 'time_series',
13-
intervalFactor: 2,
1413
legendFormat: 'error',
1514
refId: 'A',
1615
step: 10,
1716
},
1817
{
1918
expr: expr(selectorTotal) + ' - ' + expr(selectorErr),
2019
format: 'time_series',
21-
intervalFactor: 2,
2220
legendFormat: 'success',
2321
refId: 'B',
2422
step: 10,

mixin-utils/utils.libsonnet

-3
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
6666
sumBy: sumByHisto,
6767
},
6868
format: 'time_series',
69-
intervalFactor: 2,
7069
legendFormat: '%(legend)s99th percentile' % legend,
7170
refId: 'A',
7271
step: 10,
@@ -80,7 +79,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
8079
sumBy: sumByHisto,
8180
},
8281
format: 'time_series',
83-
intervalFactor: 2,
8482
legendFormat: '%(legend)s50th percentile' % legend,
8583
refId: 'B',
8684
step: 10,
@@ -94,7 +92,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
9492
sumBy: sumBy,
9593
},
9694
format: 'time_series',
97-
intervalFactor: 2,
9895
legendFormat: '%(legend)sAverage' % legend,
9996
refId: 'C',
10097
step: 10,

0 commit comments

Comments
 (0)