Skip to content

Commit f3b3d58

Browse files
committed
Mixins: draw graphs at full resolution
Remove "intervalFactor: 2", which corresponded to "Resolution 1/2" in the Grafana UI. This feature has now been dropped from the UI, and I can't see why were ever using it - why would you not want the full resolution for your panels? Left `awx-mixin/dashboards/clustertable.libsonnet` untouched because those are table queries not timeseries.
1 parent a2ba95a commit f3b3d58

File tree

4 files changed

+0
-13
lines changed

4 files changed

+0
-13
lines changed

envoy-mixin/dashboards.libsonnet

-1
Original file line numberDiff line numberDiff line change
@@ -116,7 +116,6 @@ local template = import 'grafonnet/template.libsonnet';
116116
{
117117
expr: 'sum by (status) (label_replace(rate(' + selector + '[$__interval]), "status", "${1}xx", "envoy_response_code_class", "(.*)"))',
118118
format: 'time_series',
119-
intervalFactor: 2,
120119
legendFormat: '{{status}}',
121120
refId: 'A',
122121
step: 10,

grafana-builder/grafana.libsonnet

-7
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,6 @@
248248
legendLink: legendLink,
249249
expr: ql.q,
250250
format: 'time_series',
251-
intervalFactor: 2,
252251
legendFormat: ql.l,
253252
step: 10,
254253
}
@@ -265,7 +264,6 @@
265264
expr: query,
266265
format: 'time_series',
267266
instant: true,
268-
intervalFactor: 2,
269267
refId: 'A',
270268
},
271269
],
@@ -328,7 +326,6 @@
328326
expr: qs[i],
329327
format: 'table',
330328
instant: true,
331-
intervalFactor: 2,
332329
legendFormat: '',
333330
step: 10,
334331
refId: std.char(65 + i),
@@ -404,7 +401,6 @@
404401
"status", "${1}", "%s", "([a-z]+)"))
405402
||| % [selector, statusLabelName, statusLabelName],
406403
format: 'time_series',
407-
intervalFactor: 2,
408404
legendFormat: '{{status}}',
409405
refId: 'A',
410406
step: 10,
@@ -418,23 +414,20 @@
418414
{
419415
expr: 'histogram_quantile(0.99, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
420416
format: 'time_series',
421-
intervalFactor: 2,
422417
legendFormat: '99th Percentile',
423418
refId: 'A',
424419
step: 10,
425420
},
426421
{
427422
expr: 'histogram_quantile(0.50, sum(rate(%s_bucket%s[$__rate_interval])) by (le)) * %s' % [metricName, selector, multiplier],
428423
format: 'time_series',
429-
intervalFactor: 2,
430424
legendFormat: '50th Percentile',
431425
refId: 'B',
432426
step: 10,
433427
},
434428
{
435429
expr: 'sum(rate(%s_sum%s[$__rate_interval])) * %s / sum(rate(%s_count%s[$__rate_interval]))' % [metricName, selector, multiplier, metricName, selector],
436430
format: 'time_series',
437-
intervalFactor: 2,
438431
legendFormat: 'Average',
439432
refId: 'C',
440433
step: 10,

jaeger-mixin/dashboards.libsonnet

-2
Original file line numberDiff line numberDiff line change
@@ -10,15 +10,13 @@ local g = (import 'grafana-builder/grafana.libsonnet') + {
1010
{
1111
expr: expr(selectorErr),
1212
format: 'time_series',
13-
intervalFactor: 2,
1413
legendFormat: 'error',
1514
refId: 'A',
1615
step: 10,
1716
},
1817
{
1918
expr: expr(selectorTotal) + ' - ' + expr(selectorErr),
2019
format: 'time_series',
21-
intervalFactor: 2,
2220
legendFormat: 'success',
2321
refId: 'B',
2422
step: 10,

mixin-utils/utils.libsonnet

-3
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
6666
sumBy: sumByHisto,
6767
},
6868
format: 'time_series',
69-
intervalFactor: 2,
7069
legendFormat: '%(legend)s99th Percentile' % legend,
7170
refId: 'A',
7271
step: 10,
@@ -80,7 +79,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
8079
sumBy: sumByHisto,
8180
},
8281
format: 'time_series',
83-
intervalFactor: 2,
8482
legendFormat: '%(legend)s50th Percentile' % legend,
8583
refId: 'B',
8684
step: 10,
@@ -94,7 +92,6 @@ local g = import 'grafana-builder/grafana.libsonnet';
9492
sumBy: sumBy,
9593
},
9694
format: 'time_series',
97-
intervalFactor: 2,
9895
legendFormat: '%(legend)sAverage' % legend,
9996
refId: 'C',
10097
step: 10,

0 commit comments

Comments
 (0)