This repository was archived by the owner on Oct 9, 2023. It is now read-only.
//:test-integration now depends on @graknlabs_grakn_core//:assemble-mac-zip #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lolski
reviewed
Apr 3, 2019
tests/integration/test_concept.py
Outdated
| unittest.main() | ||
|
|
||
|
|
||
| with GraknDistribution(): |
There was a problem hiding this comment.
can we call it GraknServer? since this isn't just a distribution, but rather a fully started Grakn instance
lolski
reviewed
Apr 3, 2019
| def __grakn_root_directory(self): | ||
| return os.path.join(self.__unpacked_dir, GraknDistribution.DISTRIBUTION_ROOT_DIR) | ||
|
|
||
| def __enter__(self): |
There was a problem hiding this comment.
As we've discussed over Slack, let's combine start with __enter__ and stop with __exit__. __enter__ and __exit__ are just one liners so there isn't much sense in splitting them
lolski
reviewed
Apr 3, 2019
tests/integration/base.py
Outdated
| def __exit__(self, exc_type, exc_val, exc_tb): | ||
| self.stop() | ||
|
|
||
| def start(self): |
There was a problem hiding this comment.
What if we get rid of __grakn_root_directory and compute cwd directly:
Suggested change
| def start(self): | |
| def start(self): | |
| ... | |
| sp.check_call([ | |
| 'grakn', 'server', 'start' | |
| ], cwd=os.path.join(self.__unpacked_dir, DISTRIBUTION_ROOT_DIR)) |
I think @property adds an unnecessary noise to the code, especially considering most of us here aren't Python programmers
lolski
reviewed
Apr 3, 2019
tests/integration/base.py
Outdated
| self._unpack() | ||
| sp.check_call([ | ||
| 'grakn', 'server', 'start' | ||
| ], cwd=self.__grakn_root_directory) |
tests/integration/base.py
Outdated
| def stop(self): | ||
| sp.check_call([ | ||
| 'grakn', 'server', 'stop' | ||
| ], cwd=self.__grakn_root_directory) |
lolski
approved these changes
Apr 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR?
Test should unpack, start/stop Grakn distribution within the test
Closes #2
What are the changes implemented in this PR?
@graknlabs_grakn_core//:assemble-mac-zipviadata