Skip to content

Schema Processing doesn't handle GQL String-Literal Descriptions #1819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darthtrevino opened this issue Aug 27, 2020 · 4 comments
Closed

Schema Processing doesn't handle GQL String-Literal Descriptions #1819

darthtrevino opened this issue Aug 27, 2020 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@darthtrevino
Copy link

Description

A part of the latest GraphQL Specification is string literal descriptions on schema elements. This is meant to aid developers grok a schema when using interactive tools (http://spec.graphql.org/June2018/#sec-Descriptions).

When processing a gql schema using Schema.For(readSchemaGqlFile()), the library throws an error on description fields.

Steps to reproduce

Use a description field in a GQL file

Query {
   """
   get the things
   """ 
   things: [Thing!]!
}

Expected result

The descriptions should not cause the schema read to throw an exception.

Actual result

An exception is thrown

Environment

Windows 10, Azure Functions,

@sungam3r
Copy link
Member

See graphql-dotnet/parser#33

@darthtrevino
Copy link
Author

Gotcha, thanks

@darthtrevino
Copy link
Author

Feel free to close as dupe

@sungam3r sungam3r added the duplicate This issue or pull request already exists label Aug 27, 2020
@Shane32
Copy link
Member

Shane32 commented Aug 28, 2020

Duplicate of #1640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants