tweak

jasonkuhrt · jasonkuhrt · commit f07a764f2e72 · 2025-01-31T12:35:34.000-05:00
diff --git a/packages/web/app/src/lib/hooks/use-local-storage-json.ts b/packages/web/app/src/lib/hooks/use-local-storage-json.ts
@@ -31,11 +31,10 @@ export function useLocalStorageJson<$Schema extends z.ZodType>(...args: ArgsInpu
     }
 
     // todo: Some possible improvements:
-    // - Monitor schema parse failures.
+    // - Monitor json/schema parse failures.
     // - Let caller choose an error strategy: 'return' / 'default' / 'throw'
     try {
-      const parsed = JSON.parse(storedValue);
-      return schema.parse(parsed);
+      return schema.parse(JSON.parse(storedValue));
     } catch (_) {
       return defaultValue;
     }

Original file line number	Diff line number	Diff line change
`@@ -31,11 +31,10 @@ export function useLocalStorageJson<$Schema extends z.ZodType>(...args: ArgsInpu`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`// todo: Some possible improvements:`
`34`		`- // - Monitor schema parse failures.`
	`34`	`+ // - Monitor json/schema parse failures.`
`35`	`35`	`// - Let caller choose an error strategy: 'return' / 'default' / 'throw'`
`36`	`36`	`try {`
`37`		`- const parsed = JSON.parse(storedValue);`
`38`		`- return schema.parse(parsed);`
	`37`	`+ return schema.parse(JSON.parse(storedValue));`
`39`	`38`	`} catch (_) {`
`40`	`39`	`return defaultValue;`
`41`	`40`	`}`