Skip to content

Commit d103402

Browse files
committed
Revert "Fix Subscription GraphQLRequest deserialization"
This reverts commit 836c972
1 parent d85592e commit d103402

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/subscriptions/GraphQLSubscriptionMapper.java

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -4,9 +4,7 @@
44
import graphql.ExecutionResult;
55
import graphql.kickstart.execution.GraphQLObjectMapper;
66
import graphql.kickstart.execution.GraphQLRequest;
7-
import java.io.IOException;
87
import java.util.Map;
9-
import java.util.Objects;
108
import lombok.RequiredArgsConstructor;
119

1210
@RequiredArgsConstructor
@@ -15,12 +13,7 @@ public class GraphQLSubscriptionMapper {
1513
private final GraphQLObjectMapper graphQLObjectMapper;
1614

1715
public GraphQLRequest readGraphQLRequest(Object payload) {
18-
Objects.requireNonNull(payload, "Payload is required");
19-
try {
20-
return graphQLObjectMapper.readGraphQLRequest(payload.toString());
21-
} catch (IOException e) {
22-
throw new RuntimeException(e);
23-
}
16+
return graphQLObjectMapper.getJacksonMapper().convertValue(payload, GraphQLRequest.class);
2417
}
2518

2619
public ExecutionResult sanitizeErrors(ExecutionResult executionResult) {

graphql-java-kickstart/src/main/java/graphql/kickstart/execution/subscriptions/apollo/SubscriptionStartCommand.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
import graphql.kickstart.execution.subscriptions.GraphQLSubscriptionMapper;
1111
import graphql.kickstart.execution.subscriptions.SubscriptionSession;
1212
import java.util.Collection;
13+
import java.util.Objects;
1314
import java.util.concurrent.CompletableFuture;
1415
import lombok.RequiredArgsConstructor;
1516
import lombok.extern.slf4j.Slf4j;
@@ -32,6 +33,7 @@ public void apply(SubscriptionSession session, OperationMessage message) {
3233
}
3334

3435
private CompletableFuture<ExecutionResult> executeAsync(Object payload, SubscriptionSession session) {
36+
Objects.requireNonNull(payload, "Payload is required");
3537
GraphQLRequest graphQLRequest = mapper.readGraphQLRequest(payload);
3638

3739
GraphQLSingleInvocationInput invocationInput = invocationInputFactory.create(graphQLRequest, session);

graphql-java-servlet/src/main/java/graphql/kickstart/servlet/subscriptions/FallbackSubscriptionConsumer.java

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
import graphql.kickstart.execution.subscriptions.GraphQLSubscriptionInvocationInputFactory;
88
import graphql.kickstart.execution.subscriptions.GraphQLSubscriptionMapper;
99
import graphql.kickstart.execution.subscriptions.SubscriptionSession;
10+
import java.util.Objects;
1011
import java.util.UUID;
1112
import java.util.concurrent.CompletableFuture;
1213
import java.util.function.Consumer;
@@ -30,6 +31,7 @@ public void accept(String text) {
3031
}
3132

3233
private CompletableFuture<ExecutionResult> executeAsync(Object payload, SubscriptionSession session) {
34+
Objects.requireNonNull(payload, "Payload is required");
3335
GraphQLRequest graphQLRequest = mapper.readGraphQLRequest(payload);
3436

3537
GraphQLSingleInvocationInput invocationInput = invocationInputFactory.create(graphQLRequest, session);

0 commit comments

Comments
 (0)