Skip to content
This repository was archived by the owner on Dec 19, 2023. It is now read-only.

Commit 25eaf05

Browse files
authored
Merge pull request #606 from graphql-java-kickstart/bugfix/605-error-response
fix(#605): keep custom error response
2 parents 6bb1e77 + 94de618 commit 25eaf05

File tree

4 files changed

+19
-19
lines changed

4 files changed

+19
-19
lines changed

.github/workflows/pull-request.yml

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -51,18 +51,19 @@ jobs:
5151
name: Setup Node
5252
with:
5353
node-version: 14
54-
- run: cd commitlint && npm audit
55-
name: Security audit of NPM packages
54+
# - run: cd commitlint && npm audit
55+
# name: Security audit of NPM packages
5656
- run: cd commitlint && npm ci && git ls-remote https://github.com/graphql-java-kickstart/graphql-spring-boot.git HEAD | grep -o '[0-9a-f]*' | xargs -I{} npx commitlint --from {} --verbose
5757
name: Run commitlint
58+
5859
test:
5960
name: Test run
6061
strategy:
6162
fail-fast: false
6263
matrix:
6364
os: [ ubuntu-latest, macos-latest, windows-latest ]
6465
java: [ 8, 11, 16 ]
65-
needs: [validation, commitlint, verify-google-java-format]
66+
needs: [ validation, commitlint, verify-google-java-format ]
6667
runs-on: ${{ matrix.os }}
6768
steps:
6869
- name: Checkout

commitlint/package-lock.json

Lines changed: 13 additions & 13 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

gradle.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ LIB_REFLECTIONS_VER=0.9.11
4141
LIB_APACHE_COMMONS_TEXT=1.9
4242
LIB_JSOUP_VER=1.13.1
4343
### Plugins
44-
PLUGIN_JACOCO_VER=0.8.7-SNAPSHOT
44+
PLUGIN_JACOCO_VER=0.8.7
4545
PLUGIN_SONARQUBE_VER=3.2.0
4646
PLUGIN_NEXUS_STAGING_VER=0.30.0
4747
PLUGIN_GOOGLE_JAVA_FORMAT_VER=0.9

graphql-kickstart-spring-support/src/main/java/graphql/kickstart/spring/error/GraphQLErrorFromExceptionHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@
88
import graphql.GraphqlErrorBuilder;
99
import graphql.SerializationError;
1010
import graphql.kickstart.execution.error.DefaultGraphQLErrorHandler;
11-
import graphql.kickstart.execution.error.GenericGraphQLError;
1211
import java.util.Collection;
1312
import java.util.HashMap;
1413
import java.util.List;
@@ -42,7 +41,7 @@ private Collection<GraphQLError> transform(GraphQLError error) {
4241
error.getLocations(), error.getPath(), error.getExtensions(), error.getErrorType());
4342
return extractException(error)
4443
.map(throwable -> transform(throwable, errorContext))
45-
.orElse(singletonList(new GenericGraphQLError(error.getMessage())));
44+
.orElse(singletonList(error));
4645
}
4746

4847
private Optional<Throwable> extractException(GraphQLError error) {

0 commit comments

Comments
 (0)