Skip to content

What was the changes in the graphql branch? #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
lucasfeliciano opened this issue Jul 26, 2018 · 3 comments
Closed

What was the changes in the graphql branch? #52

lucasfeliciano opened this issue Jul 26, 2018 · 3 comments

Comments

@lucasfeliciano
Copy link

Hello, I forked this branch for the use here in the company and I decided to use apollo-server instead of graphql-express.

The reason is that we use batched queries and apollo-server has this feature out of the box.

So I saw that you forked the graphql repositorie to implement some changes related to the directives.

github:apis-guru/graphql-js#directives-fork-dist

However I can't find this branch in the forked repo to see what were the changes.

I think the changes was to create/overwrite directives but now graphql provide new feature to do that: https://www.apollographql.com/docs/graphql-tools/schema-directives.html

And thats how I want to approach, but I need to know the changes that you made to continue with this :)

@IvanGoncharov
Copy link
Member

@lucasfeliciano See here: #41 (comment)

@IvanGoncharov
Copy link
Member

I think the changes was to create/overwrite directives but now graphql provide new feature to do that: apollographql.com/docs/graphql-tools/schema-directives.html

@lucasfeliciano It's apollo specific implementation and I try to keep this project vanilla GraphQL.

Hello, I forked this branch for the use here in the company and I decided to use apollo-server instead of graphql-express. The reason is that we use batched queries and apollo-server has this feature out of the box.

I plan to add support of batched queries to https://github.com/graphql/express-graphql in the near future.

@IvanGoncharov
Copy link
Member

@lucasfeliciano I finally migrated away from forked graphql and released 2.0.0-rc.1 📦 with this change.
If you have time can you please test it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants