Skip to content

Commit 7bb62ff

Browse files
authored
Make rust 1.28 minimum supported version (#285)
1 parent fe2bf61 commit 7bb62ff

File tree

4 files changed

+10
-6
lines changed

4 files changed

+10
-6
lines changed

.travis.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,8 +8,8 @@ rust:
88
- nightly
99

1010
# Prevent accidentally breaking older Rust versions
11-
- 1.23.0
12-
- 1.22.0
11+
- 1.29.0
12+
- 1.28.0
1313

1414
env:
1515
global:

_build/azure-pipelines-template.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ jobs:
1111
nightly:
1212
rustup_toolchain: nightly
1313
minimum_supported_version_plus_one:
14-
rustup_toolchain: 1.23.0
14+
rustup_toolchain: 1.29.0
1515
minimum_supported_version:
16-
rustup_toolchain: 1.22.0
16+
rustup_toolchain: 1.28.0
1717
steps:
1818
- ${{ if ne(parameters.name, 'Windows') }}:
1919
# Linux and macOS.

changelog/master.md

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,10 @@
22

33
## Changes
44

5+
- The minimum required Rust version is now `1.28.0`.
6+
7+
[#271](https://github.com/graphql-rust/juniper/pull/271)
8+
59
- Juniper is now generic about the exact representation of scalar values. This
610
allows downstream crates to add support for own scalar value representations.
711

juniper/src/schema/meta.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -788,9 +788,9 @@ fn clean_docstring(multiline: &[&str]) -> Option<String> {
788788
.map(|ch| ch.is_whitespace())
789789
.unwrap_or(false)
790790
{
791-
ln.trim_end() // skip trimming the first line
791+
ln.trim_right() // skip trimming the first line
792792
} else if ln.len() >= trim_start {
793-
&ln[trim_start..].trim_end()
793+
ln[trim_start..].trim_right()
794794
} else {
795795
""
796796
};

0 commit comments

Comments
 (0)