Skip to content

Resolve crashes in CI for Github Actions #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LegNeato opened this issue Feb 13, 2020 · 10 comments
Closed

Resolve crashes in CI for Github Actions #531

LegNeato opened this issue Feb 13, 2020 · 10 comments
Labels
k::toolchain Related to project toolchain

Comments

@LegNeato
Copy link
Member

We are now seeing crashes in GitHub CI across all platforms and Rust versions. Tracking in rust-lang/rust#69121

@LegNeato LegNeato added bug Something isn't working needs-triage blocked and removed bug Something isn't working needs-triage labels Feb 13, 2020
@LegNeato LegNeato changed the title Resolve crashes in CI Resolve crashes in CI for Github Actions Feb 21, 2020
@LegNeato LegNeato pinned this issue Feb 21, 2020
@LegNeato
Copy link
Member Author

I have disabled Github Actions in the UI until this is resolved.

@LegNeato LegNeato added the k::toolchain Related to project toolchain label Feb 21, 2020
@sagiegurari
Copy link
Contributor

I wonder if this was a temporary thing which is now resolved.
i moved all my projects to github actions and they are all working well (stable, beta, nightly and specific version).

@LegNeato
Copy link
Member Author

I renabled it, we shall see

@LegNeato
Copy link
Member Author

Nope, still the same issue.

@sagiegurari
Copy link
Contributor

looks like a rustc bug worth reporting. wdyt?

@LegNeato
Copy link
Member Author

Already reported above :-)

@msdinit
Copy link
Contributor

msdinit commented Jun 22, 2020

Not an expert by any means, but is there a reason for RUSTFLAGS: "-C link-dead-code"?

Does not look like that variable is set for Azure pipelines, and if I remove it, checks for nightly seem to pass for the most part.
And the other way around, running RUSTFLAGS="-C link-dead-code" cargo build --tests seem to reproduce the error locally

@LegNeato
Copy link
Member Author

Nice catch! I'll look into it.

@sagiegurari
Copy link
Contributor

the deadcode flag is for code coverage to be more accurate

@LegNeato LegNeato unpinned this issue Sep 3, 2020
@tyranron tyranron removed the blocked label May 11, 2021
@tyranron
Copy link
Member

With #884 we removed the RUSTFLAGS="-C link-dead-code". So this is resolved now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
k::toolchain Related to project toolchain
Projects
None yet
Development

No branches or pull requests

4 participants