From 594259945100db669f9abf53d7f9772dddac7b9c Mon Sep 17 00:00:00 2001 From: Hassan A Hashim Date: Mon, 26 Aug 2024 19:48:24 +0200 Subject: [PATCH 1/2] Fix the todo, warning sign not rendered --- src/audits/render.ts | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/audits/render.ts b/src/audits/render.ts index 8b2b4fe4..5922b3e2 100644 --- a/src/audits/render.ts +++ b/src/audits/render.ts @@ -39,8 +39,7 @@ export async function renderAuditResultsToHTML(results: AuditResult[]) { report += `
  • 💡 ${grouped.notice.length} notices (suggestions)
    • \n`; } if (grouped.warn.length) { - // TODO: warning sign is rendered as "⚠️" in markdown instead of the emoji - report += `
  • ⚠️ ${grouped.warn.length} warnings (optional)
    • \n`; + report += `
  • ❗️ ${grouped.warn.length} warnings (optional)
    • \n`; } if (grouped.error.length) { report += `
  • ❌ ${grouped.error.length} errors (required)
    • \n`; From a6ffe6ff2ffaec36d85895ed3c06adbe973f9b36 Mon Sep 17 00:00:00 2001 From: Hassan A Hashim Date: Tue, 27 Aug 2024 12:23:53 +0200 Subject: [PATCH 2/2] Update test snapshots for `src/audits` --- tests/audits.test.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/audits.test.ts b/tests/audits.test.ts index a13f4857..7dc7b22b 100644 --- a/tests/audits.test.ts +++ b/tests/audits.test.ts @@ -119,7 +119,7 @@ describe('Render audit results to HTML', () => {