Skip to content

Commit 880d3bd

Browse files
committed
review changes
1 parent 7445c67 commit 880d3bd

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

src/execution/__tests__/executor-test.ts

+7-6
Original file line numberDiff line numberDiff line change
@@ -582,7 +582,7 @@ describe('Execute: Handles basic execution tasks', () => {
582582
});
583583

584584
it('handles sync errors combined with rejections', async () => {
585-
let isAsyncResolverCalled = false;
585+
let isAsyncResolverFinished = false;
586586

587587
const schema = new GraphQLSchema({
588588
query: new GraphQLObjectType({
@@ -598,8 +598,8 @@ describe('Execute: Handles basic execution tasks', () => {
598598
await resolveOnNextTick();
599599
await resolveOnNextTick();
600600
await resolveOnNextTick();
601-
isAsyncResolverCalled = true;
602-
return Promise.resolve(null);
601+
isAsyncResolverFinished = true;
602+
return null;
603603
},
604604
},
605605
},
@@ -614,10 +614,10 @@ describe('Execute: Handles basic execution tasks', () => {
614614
}
615615
`);
616616

617-
const result = await execute({ schema, document });
617+
const result = execute({ schema, document });
618618

619-
expect(isAsyncResolverCalled).to.equal(true);
620-
expectJSON(result).toDeepEqual({
619+
expect(isAsyncResolverFinished).to.equal(false);
620+
expectJSON(await result).toDeepEqual({
621621
data: null,
622622
errors: [
623623
{
@@ -628,6 +628,7 @@ describe('Execute: Handles basic execution tasks', () => {
628628
},
629629
],
630630
});
631+
expect(isAsyncResolverFinished).to.equal(true);
631632
});
632633

633634
it('Full response path is included for non-nullable fields', () => {

0 commit comments

Comments
 (0)