Skip to content

Commit 9c90a23

Browse files
saihajbenjie
andauthored
docs: reviewer and merge process (#4013)
In GraphQL.js working group we discussed and put process in place. But we never officially wrote down in docs. You can watch this recording https://youtu.be/BBxc_HmB71I?si=cvdUMI47vBsT9F2y&t=1316 or check the transcript. These are the changes we agreed in the working group, just putting them in writing. --------- Co-authored-by: Benjie <[email protected]>
1 parent 2aedf25 commit 9c90a23

File tree

1 file changed

+10
-0
lines changed

1 file changed

+10
-0
lines changed

.github/CONTRIBUTING.md

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,16 @@ ensure your pull request matches the style guides, run `npm run prettier`.
7474
- Trailing commas,
7575
- Avd abbr wrds.
7676

77+
## Review Process
78+
79+
- Pull requests are required to pass all tests and checks before they can be merged.
80+
- Pull requests should be reviewed by _at least two_ members of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team before they can be merged; ideally reviewers affiliated with different organizations
81+
- If a reviewer hasn't responded in 48 hours, feel free to ping them `@graphql/graphql-js-reviewers`.
82+
83+
## Merge Process
84+
85+
Once a pull request has been approved by 2 reviewers from [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers) team, we must wait 2 weeks before merging the pull request, this allows for other reviewers to give feedback without rushing any merges. Pull request can be merged by a member of the [`@graphql/graphql-js-reviewers`](https://github.com/orgs/graphql/teams/graphql-js-reviewers-write) team.
86+
7787
## Release on NPM
7888

7989
_Only core contributors may release to NPM._

0 commit comments

Comments
 (0)