introduce addError instead of handleFieldError

addError calls locatedError and then adds the error as previously in
handleFieldError, throwing if the type is non-null

Author: yaacovCR

src/execution/execute.ts

@@ -668,7 +668,6 @@ function executeField(
   path: Path,
   asyncPayloadRecord?: AsyncPayloadRecord,
 ): PromiseOrValue<unknown> {
-  const errors = asyncPayloadRecord?.errors ?? exeContext.errors;
   const fieldName = fieldNodes[0].name.value;
   const fieldDef = exeContext.schema.getField(parentType, fieldName);
   if (!fieldDef) {
@@ -705,8 +704,14 @@ function executeField(
 
     result = resolveFn(source, args, contextValue, info);
   } catch (rawError) {
-    const error = locatedError(rawError, fieldNodes, pathToArray(path));
-    const handledError = handleFieldError(error, returnType, errors);
+    const errors = asyncPayloadRecord?.errors ?? exeContext.errors;
+    const handledError = addError(
+      rawError,
+      fieldNodes,
+      returnType,
+      path,
+      errors,
+    );
     filterSubsequentPayloads(exeContext, path, asyncPayloadRecord);
     return handledError;
   }
@@ -761,11 +766,15 @@ export function buildResolveInfo(
   };
 }
 
-function handleFieldError(
-  error: GraphQLError,
+function addError(
+  rawError: unknown,
+  fieldNodes: ReadonlyArray<FieldNode>,
   returnType: GraphQLOutputType,
+  path: Path,
   errors: Array<GraphQLError>,
 ): null {
+  const error = locatedError(rawError, fieldNodes, pathToArray(path));
+
   // If the field type is non-nullable, then it is resolved without any
   // protection from errors, however it still properly locates the error.
   if (isNonNullType(returnType)) {
@@ -919,8 +928,13 @@ async function completePromiseCatchingErrors(
     return completed;
   } catch (rawError) {
     const errors = asyncPayloadRecord?.errors ?? exeContext.errors;
-    const error = locatedError(rawError, fieldNodes, pathToArray(path));
-    const handledError = handleFieldError(error, returnType, errors);
+    const handledError = addError(
+      rawError,
+      fieldNodes,
+      returnType,
+      path,
+      errors,
+    );
     filterSubsequentPayloads(exeContext, path, asyncPayloadRecord);
     return handledError;
   }
@@ -948,8 +962,13 @@ function completeValueCatchingErrors(
     );
   } catch (rawError) {
     const errors = asyncPayloadRecord?.errors ?? exeContext.errors;
-    const error = locatedError(rawError, fieldNodes, pathToArray(path));
-    const handledError = handleFieldError(error, returnType, errors);
+    const handledError = addError(
+      rawError,
+      fieldNodes,
+      returnType,
+      path,
+      errors,
+    );
     filterSubsequentPayloads(exeContext, path, asyncPayloadRecord);
     return handledError;
   }
@@ -959,8 +978,13 @@ function completeValueCatchingErrors(
     // to take a second callback for the error case.
     completedValue = completedValue.then(undefined, (rawError) => {
       const errors = asyncPayloadRecord?.errors ?? exeContext.errors;
-      const error = locatedError(rawError, fieldNodes, pathToArray(path));
-      const handledError = handleFieldError(error, returnType, errors);
+      const handledError = addError(
+        rawError,
+        fieldNodes,
+        returnType,
+        path,
+        errors,
+      );
       filterSubsequentPayloads(exeContext, path, asyncPayloadRecord);
       return handledError;
     });
@@ -1066,8 +1090,9 @@ async function completeAsyncIteratorValue(
       // eslint-disable-next-line no-await-in-loop
       iteration = await iterator.next();
     } catch (rawError) {
-      const error = locatedError(rawError, fieldNodes, pathToArray(itemPath));
-      completedResults.push(handleFieldError(error, itemType, errors));
+      completedResults.push(
+        addError(rawError, fieldNodes, itemType, itemPath, errors),
+      );
       break;
     }
 
@@ -1958,8 +1983,13 @@ async function executeStreamIteratorItem(
   try {
     iteration = await iterator.next();
   } catch (rawError) {
-    const error = locatedError(rawError, fieldNodes, pathToArray(itemPath));
-    const value = handleFieldError(error, itemType, asyncPayloadRecord.errors);
+    const value = addError(
+      rawError,
+      fieldNodes,
+      itemType,
+      itemPath,
+      asyncPayloadRecord.errors,
+    );
     // don't continue if iterator throws
     return { done: true, value };
   }