Skip to content

Commit f062daf

Browse files
committed
updates following PR feedback
1 parent a6a8e91 commit f062daf

File tree

3 files changed

+8
-10
lines changed

3 files changed

+8
-10
lines changed

spec/Section 3 -- Type System.md

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -220,10 +220,6 @@ Likewise, when representing a GraphQL schema using the type system definition
220220
language, a schema definition should be omitted if it only uses the default root
221221
operation type names.
222222

223-
Likewise, when representing a GraphQL schema using the type system definition
224-
language, a schema definition should be omitted if it only uses the default root
225-
operation type names.
226-
227223
This example describes a valid complete GraphQL schema, despite not explicitly
228224
including a {`schema`} definition. The {"Query"} type is presumed to be the
229225
{`query`} root operation type of the schema.

spec/Section 5 -- Validation.md

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Validation
22

3-
GraphQL service does not just verify if a request is syntactically correct, but also
3+
A GraphQL service does not just verify if a request is syntactically correct, but also
44
ensures that it is unambiguous and mistake-free in the context of a given
55
GraphQL schema.
66

@@ -13,8 +13,9 @@ Typically validation is performed in the context of a request immediately before
1313
execution, however a GraphQL service may execute a request without explicitly
1414
validating it if that exact same request is known to have been validated before.
1515
For example: the request may be validated during development, provided it does
16-
not later change. Any client-side or development-time
17-
tool should report validation errors and not allow the
16+
not later change, or a service may validate a request once and memoize the
17+
result to avoid validating the same request again in the future. Any client-side
18+
or development-time tool should report validation errors and not allow the
1819
formulation or execution of requests known to be invalid at that given point in
1920
time.
2021

@@ -577,7 +578,7 @@ fragment conflictingDifferingResponses on Pet {
577578
- Let {selectionType} be the unwrapped result type of {selection}.
578579
- If {selectionType} is a scalar or enum:
579580
- The subselection set of that selection must be empty.
580-
- If {selectionType} is an interface, union, object or list of those types:
581+
- If {selectionType} is an interface, union, or object:
581582
- The subselection set of that selection must NOT BE empty.
582583

583584
**Explanatory Text**

spec/Section 6 -- Execution.md

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# Execution
22

3-
GraphQL service generates a response from a request via execution.
3+
A GraphQL service generates a response from a request via execution.
44

55
:: A _request_ for execution consists of a few pieces of information:
66

@@ -144,7 +144,8 @@ executing the operation’s top level selection set on the mutation root object
144144
type. This selection set should be executed serially.
145145

146146
It is expected that the top level fields in a mutation operation perform
147-
side-effects on the underlying data system.
147+
side-effects on the underlying data system. Serial execution of the provided
148+
mutations ensures against race conditions during these side-effects.
148149

149150
ExecuteMutation(mutation, schema, variableValues, initialValue):
150151

0 commit comments

Comments
 (0)