From 1b604d6b31081ca11d3945e6bd2d80397e21d3b5 Mon Sep 17 00:00:00 2001 From: Benjie Gillam Date: Sun, 25 Apr 2021 13:53:41 +0100 Subject: [PATCH] Extend `__typename` at subscription root RFC discussion --- agendas/2021-05-06.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/agendas/2021-05-06.md b/agendas/2021-05-06.md index adfc23be..4802939f 100644 --- a/agendas/2021-05-06.md +++ b/agendas/2021-05-06.md @@ -71,7 +71,9 @@ Example agenda item: - Status Update - Fields vs Input Objects 1. [Glossary RFC](https://github.com/graphql/graphql-spec/pull/846) (15m, Benjie) -1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (5m, Benjie) - - Ivan has approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861) - - Main question: have other implementors had a chance to look at this yet? +1. [Advancing `__typename` not valid at subscription root RFC](https://github.com/graphql/graphql-spec/pull/776) (30m, Benjie) + - Ivan approved [the GraphQL.js changes](https://github.com/graphql/graphql-js/pull/2861) + - Have since updated the implementation to more closely mirror the spec. + - Potential validation oversight - @skip/@include; see related RFC: https://github.com/graphql/graphql-spec/pull/860 + - Question: have other implementors had a chance to look at this yet? 1. *ADD YOUR AGENDA ABOVE*