chore: Apply latest nlm generator

Author: grpn-bulk-nlm

.eslintrc

@@ -1,3 +1,3 @@
 {
-  "extends": "groupon-es5"
+  "extends": "groupon/node4"
 }

.gitignore

@@ -1,3 +1,5 @@
+/yarn.lock
+/package-lock.json
 node_modules/
 npm-debug.log
 /tmp

.travis.yml

@@ -1,21 +1,16 @@
 language: node_js
 node_js:
-  - '0.10'
-  - '4'
-  - '6'
+  - 4.6.1
+  - 6.11.5
+  - 8.9.0
+deploy:
+  - provider: script
+    script: ./node_modules/.bin/nlm release
+    skip_cleanup: true
+    'on':
+      branch: master
+      node: 8.9.0
 addons:
   apt:
     packages:
       - oracle-java8-set-default
-before_install:
-  - npm install -g npm@latest-2
-before_deploy:
-  - git config --global user.email "[email protected]"
-  - git config --global user.name "Groupon"
-deploy:
-  provider: script
-  script: ./node_modules/.bin/nlm release
-  skip_cleanup: true
-  'on':
-    branch: master
-    node: '6'

CONTRIBUTING.md

@@ -1,4 +1,4 @@
-<!-- Generated by generator-nlm -->
+<!-- Generated by generator-js -->
 
 # Contributing
 
@@ -31,7 +31,7 @@ If you report a bug, please follow these guidelines:
 
 For small documentation changes, you can use [Github's editing feature](https://help.github.com/articles/editing-files-in-another-user-s-repository/).
 The only thing to keep in mind is to prefix the commit message with "docs: ".
-The detault commit message generated by Github will lead to a failing CI build.
+The default commit message generated by Github will lead to a failing CI build.
 
 For larger updates to the documentation
 it might be better to follow the [instructions for contributing code below](#contributing-code).
@@ -52,7 +52,7 @@ The general steps for creating a pull request are:
 1. If you're fixing a bug, be sure to write a test *first*.
    That way you can validate that the test actually catches the bug and doesn't pass.
 1. Make your changes to the code.
-   Remember to update the tests if you add new features or change behavior. 
+   Remember to update the tests if you add new features or change behavior.
 1. Run the tests via `npm test`. This will also run style checks and other validations.
    You might see errors about uncommitted files.
    This is expected until you commit your changes.

lib/checksum.js

@@ -29,24 +29,26 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
-var fs = require('fs');
-var createHash = require('crypto').createHash;
+
+const fs = require('fs');
+const createHash = require('crypto').createHash;
 
 function verifyChecksum(filePath, checksum, callback) {
-  var hash = createHash('md5');
-  var stream = fs.createReadStream(filePath);
+  const hash = createHash('md5');
+  const stream = fs.createReadStream(filePath);
   stream.on('data', function updateHash(data) {
     return hash.update(data);
   });
 
   function digestAndVerify() {
-    var digest = hash.digest('base64');
+    const digest = hash.digest('base64');
     if (digest === checksum) return callback();
 
-    var message =
-      'File ' + filePath + ' did not match checksum: ' +
-      'expected ' + checksum + ' but saw ' + digest;
+    const message =
+      `File ${filePath} did not match checksum: ` +
+      `expected ${checksum} but saw ${digest}`;
     return callback(new Error(message));
   }
 

lib/chromedriver/download.js

@@ -29,32 +29,33 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
-var fs = require('fs');
 
-var async = require('async');
-var debug = require('debug')('selenium-download:chromedriver:download');
-var fsExtra = require('fs.extra');
-var AdmZip = require('adm-zip');
-var _ = require('lodash');
+const fs = require('fs');
+
+const async = require('async');
+const debug = require('debug')('selenium-download:chromedriver:download');
+const fsExtra = require('fs.extra');
+const AdmZip = require('adm-zip');
+const _ = require('lodash');
 
-var downloadFile = require('../download');
-var validate = require('../checksum');
+const downloadFile = require('../download');
+const validate = require('../checksum');
 
-var copy = fsExtra.copy;
-var move = fsExtra.move;
+const copy = fsExtra.copy;
+const move = fsExtra.move;
 
-var extension = process.platform === 'win32' ? '.exe' : '';
+const extension = process.platform === 'win32' ? '.exe' : '';
 
 function unzip(tempPath, filePath, callback) {
-  var tempFilePath = filePath + '.tmp';
+  const tempFilePath = `${filePath}.tmp`;
 
   function onMoved(error) {
-    var zip;
     if (error != null) {
       return callback(error);
     }
-    zip = new AdmZip(tempFilePath);
+    const zip = new AdmZip(tempFilePath);
     zip.extractAllTo(tempPath);
     fs.unlinkSync(tempFilePath);
     return callback();
@@ -64,7 +65,7 @@ function unzip(tempPath, filePath, callback) {
 }
 
 function isValidExecutable(filename) {
-  var stat;
+  let stat;
   try {
     stat = fs.statSync(filename);
   } catch (err) {
@@ -91,13 +92,13 @@ function copyReplace(source, dest, callback) {
 }
 
 function downloadChromeDriver(binPath, tempPath, version, url, callback) {
-  var chromedriverPath = binPath + '/chromedriver';
+  const chromedriverPath = `${binPath}/chromedriver`;
   if (isValidExecutable(chromedriverPath)) {
     debug('already downloaded', chromedriverPath);
     return callback();
   }
-  var tempFileName = 'chromedriver_' + version;
-  var tempFilePath = tempPath + '/' + tempFileName;
+  const tempFileName = `chromedriver_${version}`;
+  const tempFilePath = `${tempPath}/${tempFileName}`;
 
   function makeExecutable(error) {
     if (error != null) {
@@ -115,13 +116,16 @@ function downloadChromeDriver(binPath, tempPath, version, url, callback) {
   debug('tmp file', tempFilePath);
   debug('target file', chromedriverPath);
 
-  var unzippedFilePath = tempPath + '/chromedriver' + extension;
-  return async.waterfall([
-    _.partial(downloadFile, url, tempPath, tempFileName),
-    _.partial(validate, tempFilePath),
-    _.partial(unzip, tempPath, tempFilePath),
-    _.partial(move, unzippedFilePath, tempFilePath),
-    _.partial(copyReplace, tempFilePath, chromedriverPath)
-  ], makeExecutable);
+  const unzippedFilePath = `${tempPath}/chromedriver${extension}`;
+  return async.waterfall(
+    [
+      _.partial(downloadFile, url, tempPath, tempFileName),
+      _.partial(validate, tempFilePath),
+      _.partial(unzip, tempPath, tempFilePath),
+      _.partial(move, unzippedFilePath, tempFilePath),
+      _.partial(copyReplace, tempFilePath, chromedriverPath),
+    ],
+    makeExecutable
+  );
 }
 module.exports = downloadChromeDriver;

lib/chromedriver/index.js

@@ -29,9 +29,11 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
-var download = require('./download');
-var getLatestVersion = require('./version');
+
+const download = require('./download');
+const getLatestVersion = require('./version');
 
 function downloadChromeDriver(binPath, tempPath) {
   return function withCallback(callback) {
@@ -40,8 +42,17 @@ function downloadChromeDriver(binPath, tempPath) {
         return callback(error);
       }
       /* eslint no-console: 0 */
-      console.log('[testium] grabbing selenium chromedriver %s', metadata.version);
-      return download(binPath, tempPath, metadata.version, metadata.downloadUrl, callback);
+      console.log(
+        '[testium] grabbing selenium chromedriver %s',
+        metadata.version
+      );
+      return download(
+        binPath,
+        tempPath,
+        metadata.version,
+        metadata.downloadUrl,
+        callback
+      );
     });
   };
 }

lib/chromedriver/version.js

@@ -29,19 +29,22 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
-var FALLBACK_CHROMEDRIVER_VERSION = '2.23';
 
-var request = require('request');
+const FALLBACK_CHROMEDRIVER_VERSION = '2.23';
+
+const request = require('request');
 
 function getArchitecture() {
-  var platform = process.platform;
+  let platform = process.platform;
   if (platform !== 'linux' && platform !== 'darwin' && platform !== 'win32') {
     throw new Error(
-      'Unsupported platform ' + platform + '. ' +
-      'Only linux, darwin, and win32 are supported.');
+      `Unsupported platform ${platform}. ` +
+        `Only linux, darwin, and win32 are supported.`
+    );
   }
-  var bitness = process.arch.substr(1);
+  let bitness = process.arch.substr(1);
   if (platform === 'darwin') {
     platform = 'mac';
     bitness = '64';
@@ -52,7 +55,7 @@ function getArchitecture() {
   }
   return {
     platform: platform,
-    bitness: bitness
+    bitness: bitness,
   };
 }
 
@@ -63,7 +66,10 @@ function getLatestVersion(callback) {
     }
     return callback(null, body);
   }
-  return request('https://chromedriver.storage.googleapis.com/LATEST_RELEASE', onBody);
+  return request(
+    'https://chromedriver.storage.googleapis.com/LATEST_RELEASE',
+    onBody
+  );
 }
 
 function getLatestDownloadInfo(callback) {
@@ -72,21 +78,21 @@ function getLatestDownloadInfo(callback) {
       version = FALLBACK_CHROMEDRIVER_VERSION;
       /* eslint no-console: 0 */
       console.log(
-        '[testium] Unable to determine latest version of selenium chromedriver; using %s', version);
+        '[testium] Unable to determine latest version of selenium chromedriver; using %s',
+        version
+      );
       console.error(error.stack || error);
     } else {
       version = version.trim();
     }
-    var arch = getArchitecture();
-    var platform = arch.platform;
-    var bitness = arch.bitness;
-    var downloadUrl =
-      'https://chromedriver.storage.googleapis.com/' + version +
-      '/chromedriver_' + platform + bitness + '.zip';
+    const arch = getArchitecture();
+    const platform = arch.platform;
+    const bitness = arch.bitness;
+    const downloadUrl = `https://chromedriver.storage.googleapis.com/${version}/chromedriver_${platform}${bitness}.zip`;
 
     return callback(null, {
       downloadUrl: downloadUrl,
-      version: version
+      version: version,
     });
   }
 

lib/download.js

@@ -29,39 +29,47 @@
  * NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS
  * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
+
 'use strict';
-var fs = require('fs');
-var path = require('path');
 
-var _ = require('lodash');
-var request = require('request');
+const fs = require('fs');
+const path = require('path');
+
+const _ = require('lodash');
+const request = require('request');
 
 function parseHashes(rawHash) {
   function parse(result, hash) {
-    var parts = hash.trim().split('=');
-    var key = parts[0];
-    var value = parts.splice(1).join('=');
+    const parts = hash.trim().split('=');
+    const key = parts[0];
+    const value = parts.splice(1).join('=');
     result[key] = value;
     return result;
   }
-  var hashes = rawHash.split(',');
+  const hashes = rawHash.split(',');
   return hashes.reduce(parse, {});
 }
 
 function downloadWithMD5(url, destinationDir, fileName, callback) {
   function onResponse(err, response, body) {
     if (err) return callback(err);
     if (response.statusCode !== 200) {
-      return callback(new Error(response.statusCode + ' - failed to download ' + url));
+      return callback(
+        new Error(`${response.statusCode} - failed to download ${url}`)
+      );
     }
 
-    var rawHash = response.headers['x-goog-hash'];
+    const rawHash = response.headers['x-goog-hash'];
     if (!rawHash) {
-      return callback(new Error('Response did not contain a checksum: ' + url));
+      return callback(new Error(`Response did not contain a checksum: ${url}`));
     }
 
-    var absoluteFile = path.join(destinationDir, fileName);
-    return fs.writeFile(absoluteFile, body, _.partial(callback, _, parseHashes(rawHash).md5));
+    const absoluteFile = path.join(destinationDir, fileName);
+    return fs.writeFile(
+      absoluteFile,
+      body,
+      _.partial(callback, _, parseHashes(rawHash).md5)
+    );
   }
 
   request(url, { gzip: true, encoding: null }, onResponse);