fix: only download latest version with server

some of the recent releases (e.g. 3.150.*) no longer seem to have the
selenium-server-standalone in them, so limit our fetches to those that
do.

Fixes: #51

Author: dbushong

lib/selenium/version.js

@@ -34,7 +34,6 @@
 
 const request = require('request');
 const parseXml = require('xml2js').parseString;
-const _ = require('lodash');
 const Semver = require('semver');
 
 function buildDownloadUrl(version, minorVersion) {
@@ -43,43 +42,21 @@ function buildDownloadUrl(version, minorVersion) {
 
 const FALLBACK_SELENIUM_VERSION = '3.9.1';
 
-function addPrefix(lookup, prefixEntry) {
-  const prefix = `${prefixEntry.Prefix}`;
-  const prefixMatch = prefix.match(/^(\d+\.\d+)\/$/);
-  if (prefixMatch) {
-    const minorVersion = prefixMatch[1];
-    const semver = Semver.coerce(minorVersion);
-    lookup[semver] = { error: null, minorVersion: minorVersion };
-  }
-  return lookup;
-}
-
-function parseSeleniumMinor(result) {
-  try {
-    const prefixes = result.ListBucketResult.CommonPrefixes.reduce(
-      addPrefix,
-      {}
-    );
-    // Once 4.x is stable, we can go back to '*' or '<5' as our base range.
-    const latest = Semver.maxSatisfying(Object.keys(prefixes), '<4');
-    return prefixes[latest];
-  } catch (parseError) {
-    return { error: parseError, minorVersion: null };
-  }
-}
-
 function parseSelenium(result) {
   try {
     const contents = result.ListBucketResult.Contents;
-    const standalone = _.find(contents, content => {
-      return content.Key[0].match(
-        /selenium-server-standalone-\d+.\d+.\d+\.jar$/
-      );
-    });
-    return {
-      error: null,
-      version: standalone.Key[0].match(/(\d+\.\d+\.\d+)/)[0],
-    };
+    const standalone = contents
+      .filter(content => {
+        return content.Key[0].match(
+          /selenium-server-standalone-\d+.\d+.\d+\.jar$/
+        );
+      })
+      .map(s => s.Key[0].match(/(\d+\.\d+\.\d+)/)[0]);
+
+    // Once 4.x is stable, we can go back to '*' or '<5' as our base range.
+    const latest = Semver.maxSatisfying(standalone, '<4');
+
+    return { error: null, version: latest };
   } catch (parseError) {
     return { error: parseError, version: null };
   }
@@ -109,8 +86,7 @@ function getMinor(version) {
 }
 
 function getLatestVersion(callback) {
-  const url =
-    'https://selenium-release.storage.googleapis.com/?delimiter=/&prefix=';
+  const url = 'https://selenium-release.storage.googleapis.com/';
 
   function onFullVersionData(error, result) {
     if (error != null) {
@@ -120,19 +96,7 @@ function getLatestVersion(callback) {
     return callback(parsed.error, parsed.version);
   }
 
-  function onMinorVersionData(error, result) {
-    if (error != null) {
-      return callback(error);
-    }
-    const parsedMinor = parseSeleniumMinor(result);
-    if (parsedMinor.error) {
-      return callback(parsedMinor.error);
-    }
-    const prefixedUrl = `https://selenium-release.storage.googleapis.com/?delimiter=/&prefix=${parsedMinor.minorVersion}/`;
-    return requestXml(prefixedUrl, onFullVersionData);
-  }
-
-  return requestXml(url, onMinorVersionData);
+  return requestXml(url, onFullVersionData);
 }
 
 function getLatestDownloadInfo(callback) {