Skip to content

Commit af01908

Browse files
grpc-api/stub: Renamed convert() method to convertToNanos()
1 parent bf6c521 commit af01908

File tree

5 files changed

+11
-11
lines changed

5 files changed

+11
-11
lines changed

api/src/main/java/io/grpc/CallOptions.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package io.grpc;
1818

1919
import static com.google.common.base.Preconditions.checkArgument;
20-
import static io.grpc.TimeUtils.convert;
20+
import static io.grpc.TimeUtils.convertToNanos;
2121

2222
import com.google.common.base.MoreObjects;
2323
import com.google.common.base.Preconditions;
@@ -179,7 +179,7 @@ public CallOptions withDeadlineAfter(long duration, TimeUnit unit) {
179179
}
180180

181181
public CallOptions withDeadlineAfter(Duration duration) {
182-
return withDeadlineAfter(convert(duration), TimeUnit.NANOSECONDS);
182+
return withDeadlineAfter(convertToNanos(duration), TimeUnit.NANOSECONDS);
183183
}
184184

185185
/**

api/src/main/java/io/grpc/SynchronizationContext.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818

1919
import static com.google.common.base.Preconditions.checkNotNull;
2020
import static com.google.common.base.Preconditions.checkState;
21-
import static io.grpc.TimeUtils.convert;
21+
import static io.grpc.TimeUtils.convertToNanos;
2222

2323
import java.lang.Thread.UncaughtExceptionHandler;
2424
import java.time.Duration;
@@ -198,7 +198,7 @@ public String toString() {
198198
public final ScheduledHandle scheduleWithFixedDelay(
199199
final Runnable task, Duration initialDelay, Duration delay,
200200
ScheduledExecutorService timerService) {
201-
return scheduleWithFixedDelay(task, convert(initialDelay), convert(delay),
201+
return scheduleWithFixedDelay(task, convertToNanos(initialDelay), convertToNanos(delay),
202202
TimeUnit.NANOSECONDS, timerService);
203203
}
204204

api/src/main/java/io/grpc/TimeUtils.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
import java.time.Duration;
2020

2121
public final class TimeUtils {
22-
public static long convert(Duration duration) {
22+
public static long convertToNanos(Duration duration) {
2323
try {
2424
return duration.toNanos();
2525
} catch (ArithmeticException tooBig) {

api/src/test/java/io/grpc/TimeUtilsTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,28 +32,28 @@ public void testConvertNormalDuration() {
3232
Duration duration = Duration.ofSeconds(10);
3333
long expected = 10 * 1_000_000_000L;
3434

35-
assertEquals(expected, TimeUtils.convert(duration));
35+
assertEquals(expected, TimeUtils.convertToNanos(duration));
3636
}
3737

3838
@Test
3939
public void testConvertNegativeDuration() {
4040
Duration duration = Duration.ofSeconds(-3);
4141
long expected = -3 * 1_000_000_000L;
4242

43-
assertEquals(expected, TimeUtils.convert(duration));
43+
assertEquals(expected, TimeUtils.convertToNanos(duration));
4444
}
4545

4646
@Test
4747
public void testConvertTooLargeDuration() {
4848
Duration duration = Duration.ofSeconds(Long.MAX_VALUE / 1_000_000_000L + 1);
4949

50-
assertEquals(Long.MAX_VALUE, TimeUtils.convert(duration));
50+
assertEquals(Long.MAX_VALUE, TimeUtils.convertToNanos(duration));
5151
}
5252

5353
@Test
5454
public void testConvertTooLargeNegativeDuration() {
5555
Duration duration = Duration.ofSeconds(Long.MIN_VALUE / 1_000_000_000L - 1);
5656

57-
assertEquals(Long.MIN_VALUE, TimeUtils.convert(duration));
57+
assertEquals(Long.MIN_VALUE, TimeUtils.convertToNanos(duration));
5858
}
5959
}

stub/src/main/java/io/grpc/stub/AbstractStub.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
package io.grpc.stub;
1818

1919
import static com.google.common.base.Preconditions.checkNotNull;
20-
import static io.grpc.TimeUtils.convert;
20+
import static io.grpc.TimeUtils.convertToNanos;
2121

2222
import io.grpc.CallCredentials;
2323
import io.grpc.CallOptions;
@@ -152,7 +152,7 @@ public final S withDeadlineAfter(long duration, TimeUnit unit) {
152152
}
153153

154154
public final S withDeadlineAfter(Duration duration) {
155-
return withDeadlineAfter(convert(duration), TimeUnit.NANOSECONDS);
155+
return withDeadlineAfter(convertToNanos(duration), TimeUnit.NANOSECONDS);
156156
}
157157

158158
/**

0 commit comments

Comments
 (0)