Merge pull request #2644 from murgatroid99/grpc-js_channelz_socket_connecting_handle_fix

murgatroid99 · web-flow · commit b8dc020167d9 · 2024-01-16T15:13:22.000-08:00
grpc-js: Shutdown transport if a state change occurs while connecting
diff --git a/packages/grpc-js/src/subchannel.ts b/packages/grpc-js/src/subchannel.ts
@@ -245,6 +245,10 @@ export class Subchannel {
                 );
               }
             });
+          } else {
+            /* If we can't transition from CONNECTING to READY here, we will
+             * not be using this transport, so release its resources. */
+            transport.shutdown();
           }
         },
         error => {

Original file line number	Diff line number	Diff line change
`@@ -245,6 +245,10 @@ export class Subchannel {`
`245`	`245`	`);`
`246`	`246`	`}`
`247`	`247`	`});`
	`248`	`+ } else {`
	`249`	`+ /* If we can't transition from CONNECTING to READY here, we will`
	`250`	`+ * not be using this transport, so release its resources. */`
	`251`	`+ transport.shutdown();`
`248`	`252`	`}`
`249`	`253`	`},`
`250`	`254`	`error => {`